Bug fixes about scroller#123
Open
yl12053 wants to merge 5 commits into
Open
Conversation
# Conflicts: # build.gradle
1. The scroller touch area should be 31 ~ 85 but not 9 + 54 2. The mouseClicked wrongly short-cut once the window cannot show up to 12 elements fully
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts UI click handling and scrollbar hitbox positioning in selection screens, and updates the Curios Maven source and dependency version.
Changes:
- Prevent early exit from
mouseClickedwhen the result list is shorter than the loop range (usebreakinstead of delegating tosupermid-loop). - Move the scrollbar click target down (
topPos + 9→topPos + 31) in both selection screens. - Update Curios Maven repo URL and bump
curios-neoforgedependency version.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/main/java/net/tracen/umapyoi/client/screen/UmaSelectScreen.java |
Tweaks click loop control flow and updates scroller hitbox Y offset. |
src/main/java/net/tracen/umapyoi/client/screen/RaceSelectScreen.java |
Same click loop + scroller hitbox Y offset updates as UmaSelectScreen. |
build.gradle |
Switches Curios Maven repo URL and bumps Curios dependency version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
329
to
+331
| for (int l = this.startIndex; l < k; ++l) { | ||
| if(l >= this.getResults().size()) | ||
| return super.mouseClicked(pMouseX, pMouseY, pButton); | ||
| break; |
|
|
||
| i = this.leftPos + 119; | ||
| j = this.topPos + 9; | ||
| j = this.topPos + 31; |
Comment on lines
285
to
+287
| for (int l = this.startIndex; l < k; ++l) { | ||
| if(l >= this.getResults().size()) | ||
| return super.mouseClicked(pMouseX, pMouseY, pButton); | ||
| break; |
|
|
||
| i = this.leftPos + 119; | ||
| j = this.topPos + 9; | ||
| j = this.topPos + 31; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.