修复部分 ComboState 在下界或其他某些情况下会丢失 tickAction 的问题#187
Open
mrqx0195 wants to merge 2 commits into
Open
Conversation
问题的根源是相同 ComboState 和 TimeLineTickAction 都是单例，不应持有非静态字段
# Conflicts: # src/main/java/mods/flammpfeil/slashblade/registry/combo/ComboState.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题的根源是相同 ComboState 和 TimeLineTickAction 都是单例，不应持有频繁变化的非静态字段。
这里是一种解决方案，不算优雅，但有效。