build(gradle): fix acceleratedrendering dependency and robustify maven_loc#186
Open
finiscontiral wants to merge 1 commit into
Open
build(gradle): fix acceleratedrendering dependency and robustify maven_loc#186finiscontiral wants to merge 1 commit into
finiscontiral wants to merge 1 commit into
Conversation
…n_loc - Fix a broken Modrinth dependency for acceleratedrendering by switching to CurseMaven. - Make local maven publishing optional to prevent build errors in other environments. - Introduced `default_maven_loc` as a fallback. - The publishing block is now safely skipped if neither path exists on the host system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two build-related issues to improve repository portability and fix broken dependencies:
acceleratedrenderingfrom a non-existent Modrinth coordinates to a valid CurseMaven coordinate.publishingblock to avoid absolute path dependencies. It now usesdefault_maven_locas a fallback and safely skips the block if neither path exists, preventing build errors on other developers' environments (like macOS).No logic inside the mod is modified. Testing completed on macOS (M4).