fix: apply 4 security patches to BaseCreditPool#329
Open
bin-57blocks wants to merge 3 commits into
Open
Conversation
bin-57blocks
commented
May 18, 2026
bin-57blocks
commented
Contributor
- Patch 1: disable requestCredit (no-op, use approveCredit instead)
- Patch 2: restrict triggerDefault to EA service account
- Patch 3: refreshAccount only processes GoodStanding/Delayed (silent no-op otherwise)
- Patch 4: prevent Defaulted state from being reset to GoodStanding in _updateDueInfo
bin-57blocks
force-pushed
the
security-patches
branch
from
7639858 to
cab0eaf
Compare
bin-57blocks
force-pushed
the
security-patches
branch
from
cab0eaf to
f462da2
Compare
wisdant
approved these changes
May 19, 2026
- HDT: add _beforeTokenTransfer hook, only mint/burn allowed, user transfers revert with transferNotAllowed() - BaseCreditPool: refreshAccount restricted to PDS service account via onlyPDSServiceAccount() - Errors: add transferNotAllowed() custom error - Tests: add HDT transfer block test, refreshAccount PDS rejection test, fix all bare refreshAccount calls
wisdant
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.