feat(distribution): homebrew cask template + design#29
Conversation
…sign
Adds 'docs/zeus-distribution.md' covering the full distribution path
(macOS .dmg + Homebrew tap, Linux .deb/.rpm/.AppImage, Windows .exe),
plus 'build/distribution/homebrew-cask.rb.template' as the substitute-
at-release-time template for the Homebrew Cask formula.
The Cask itself will live in a separate tap repo
('0-draft/homebrew-zeus', file 'Casks/zeus.rb') because Homebrew taps
must be named 'homebrew-*'. The template ruby file is syntax-valid
('ruby -c' passes).
Calls out the zoxide collision (Zeus's release binary is 'z', zoxide
uses 'z' too) in the install notes.
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 1 minute and 3 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the distribution strategy for Zeus, including a Homebrew Cask template and documentation for macOS, Linux, and Windows releases. The review feedback suggests improving the Homebrew Cask by removing a redundant 'verified' parameter and expanding the 'zap' stanza to ensure a cleaner uninstallation. There is also a recommendation to change the default binary name from 'z' to 'zeus' to avoid conflicts with common tools like zoxide.
- Remove 'verified:' parameter — redundant when url host matches the homepage host (brew audit flags it for GitHub-hosted releases) - Expand zap trash to cover the standard set of Electron / VS Code state paths so 'brew uninstall --zap' is actually clean: Caches, ShipIt cache, HTTPStorages, Logs, alongside the existing App Support / Preferences / Saved Application State / ~/.zeus
|
Re. binary name The zoxide collision is real but expected: users who actively use zoxide will need to alias one of the two. Documented in |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a Homebrew Cask template and detailed distribution documentation for the Zeus code editor across macOS, Linux, and Windows. Feedback focuses on enhancing the Cask configuration by adding a binary stanza to provide a command-line interface and expanding the zap stanza to ensure a more thorough cleanup of application data upon uninstallation. Corresponding updates to the documentation were also recommended to maintain consistency with the template.
…list) - binary stanza so 'brew install --cask zeus' puts 'z' on PATH out of the box. Points at the in-bundle 'bin/z' shipped by the gulp packaging step. zoxide collision is still real and is documented separately. - zap additions: - ~/Library/WebKit/com.0draft.zeus (webview caches) - sharedfilelist sfl3 entry (macOS recent-documents tracking) - Mirrored in docs/zeus-distribution.md so the example Cask in the doc matches the shipped template.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request establishes the distribution strategy for the Zeus editor, introducing a Homebrew Cask template and detailed documentation for macOS, Linux, and Windows releases. The review feedback suggests renaming the default CLI binary from z to zeus to prevent conflicts with existing tools like zoxide and identifies a discrepancy between the documentation and the template regarding the files managed by the zap command.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a Homebrew Cask template and a comprehensive distribution strategy document for the Zeus editor, covering installation methods, code signing, and update mechanisms across macOS, Linux, and Windows. Feedback was provided regarding incorrect documentation of Homebrew Cask CLI flags; specifically, the --binary flag is not supported, and the documentation should instead suggest using --no-binaries or manual symlinking to resolve command collisions.
1 participant
Goal
Document the distribution path (macOS .dmg / Homebrew, Linux .deb/.rpm/.AppImage, Windows .exe) and scaffold the Homebrew Cask template.
Design: `docs/zeus-distribution.md`
What this PR ships
What this PR does NOT ship
Open questions
Install command (target)
```text
brew tap 0-draft/zeus
brew install --cask zeus
```