fix: serve companion-tokens at the user-scoped path the web UI calls#40
Merged
Conversation
Account → Companion always showed "No computers connected" even with a companion linked. The list/revoke routes were mounted under /api/projects/:projectId/companion-tokens, but the handlers are user-scoped (listCompanionTokensByUser, ignores projectId) and the web client calls the top-level /api/companion-tokens. Every request 404'd, so the query came back empty. Register the routes where the client actually calls them: GET /api/companion-tokens DELETE /api/companion-tokens/:tokenId Both still sit before the /api/* catch-all, so matching is unchanged. Server-only fix; the frontend already used the correct paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Account → Companion always showed "No computers connected" even when a laptop was linked.
The list/revoke routes were mounted under a project-scoped path:
…but the handlers are user-scoped (
listCompanionTokensByUser, ignoresprojectId), and the web client (web/src/api/companion-tokens.ts) calls the top-level path:So every request 404'd and the query returned empty — the panel rendered its empty state. This never worked, not a regression from the recent companion changes.
Fix
Register the routes at the path the client actually calls. They still sit before the
/api/*catch-all, so match precedence is unchanged.:tokenIdresolves via Hono'sc.req.param()exactly as before. Server-only change.Testing
webcalls/api/companion-tokens(+/:tokenId) and nothing references the old project-scoped path.app.all("/api/*")(line ~557) andapp.get("*")static handler, so it matches first.After deploy, Account → Companion lists connected computers (name, project, last-used, expiry) and revoke works.
🤖 Generated with Claude Code