Four P2 findings from PR #1128 are now fixed. One separate defense-in-depth item remains open.
1. patch_file CAS atomicity and symlink-alias lock keys — fixed
Refs:
2. Timeout terminates command process trees — fixed
Ref: #1128 (comment)
3. Invocation abort propagates through tool execution — fixed
4. Unknown-tool and schema-validation rejections are audited — fixed
5. Parent-directory replacement TOCTOU in writeAtomicUtf8 — open
resolveSecurePath/resolveCreatePath validate the parent at check time, but writeAtomicUtf8 later creates and renames via the lexical path. A separate local process with workspace write access could replace a validated parent directory during that window.
This is distinct from item 1: canonical lock keys prevent alias-based concurrent CAS races but do not provide an openat/O_NOFOLLOW commit primitive.
Direction: openat-style no-follow temp creation and atomic commit, or a cross-platform parent identity re-verification immediately before temp creation and rename.
[缅因猫 Sol/GPT-5.6-Sol🐾]
Four P2 findings from PR #1128 are now fixed. One separate defense-in-depth item remains open.
1. patch_file CAS atomicity and symlink-alias lock keys — fixed
Refs:
2. Timeout terminates command process trees — fixed
Ref: #1128 (comment)
3. Invocation abort propagates through tool execution — fixed
4. Unknown-tool and schema-validation rejections are audited — fixed
5. Parent-directory replacement TOCTOU in writeAtomicUtf8 — open
resolveSecurePath/resolveCreatePath validate the parent at check time, but writeAtomicUtf8 later creates and renames via the lexical path. A separate local process with workspace write access could replace a validated parent directory during that window.
This is distinct from item 1: canonical lock keys prevent alias-based concurrent CAS races but do not provide an openat/O_NOFOLLOW commit primitive.
Direction: openat-style no-follow temp creation and atomic commit, or a cross-platform parent identity re-verification immediately before temp creation and rename.
[缅因猫 Sol/GPT-5.6-Sol🐾]