#12) (#15) * fix(components): Field#radio keeps its own value, not the model's field_attributes carries value: field_value (the model's CURRENT value) and was splatted after the explicit positional radio value, clobbering it. A new record lost the value entirely; an edit form gave every radio in the group the same value. radio now drops field_attributes' value (the sibling checkbox/toggle/file builders already do .except(:value)), so each radio keeps its own value and an explicit value: option still wins. ## Test Coverage - keeps each radio's own value instead of the model's current value - checks the radio whose value matches the model, not all of them - still lets an explicit value: option win ## Verification - [x] bundle exec rubocop lib spec passes - [x] bundle exec rspec passes Refs #13 * fix(engine): validation controller identifiers resolve via lazyLoadControllersFrom data-controller="forms--validations--length" derives (via stimulus-loading's controllerFilename) the import path phlex_forms/controllers/forms/validations/ length_controller — but the files ship at phlex_forms/controllers/validations/ length_controller (no forms/ segment). The import 404'd and the controllers never connected, so client-side validation silently did nothing (issue #12). Drop the forms-- prefix: CONTROLLER_PREFIX is now "validations", so data-controller="validations--length" resolves to the shipped path. The change cascades from the single constant to the emitted identifier AND the data-validations--*-value attribute names (data_key uses the same prefix). Also updated to match: form.rb now derives the coordinator id from the constant (so form-level and field-level can't drift), the JS invalidate:validations event, the data-validations--error / --counter markers, specs, README, and the docs page. BREAKING: hosts that registered forms--validations--* controllers explicitly must update the identifier to validations--*. ## Test Coverage - introspector emits validations--presence / validations--length + the validations__*_value data keys - components_spec: the coordinator (validations--form), submit action, and per-field controllers all use the new prefix - verified every emitted identifier resolves to a shipped *_controller.js path ## Verification - [x] bundle exec rubocop lib spec passes - [x] bundle exec rspec passes (144 examples) - [x] no surviving forms--validations / forms__validations references anywhere Refs #12

Uh oh!

Bug: Field#radio lets field_attributes clobber the positional radio value #13

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions