…10 #11 #9) (#14) * fix(shell): fields_for treats a Hash-backed association as a single scope A Hash responds to #each_with_index, so a JSONB column rendered with nested_attributes: false was iterated as [key, value] pairs, emitting scope[assoc][0][field], [1], ... instead of a single scope[assoc][field]. Only genuine collections (Enumerable, not Hash) iterate now — Enumerable covers Array and ActiveRecord::Relation without a hard AR dependency; a Hash / single record / Struct / PORO falls through to the single-scope branch. ## Test Coverage - treats a Hash-backed association as a single nested scope, not a collection (asserts name="record[profile][phone]", no [0]/[1] indices) ## Verification - [x] bundle exec rubocop lib spec passes - [x] bundle exec rspec passes Refs #10 * fix(shell): wire the validation coordinator's submit handler Form(validate: true) attached the forms--validations--form controller and novalidate, but no data-action wired its onSubmit handler — the controller connected yet onSubmit never fired, so submitting an invalid form was not blocked client-side. apply_validation_coordinator now emits `submit->forms--validations--form#onSubmit`, joined with any caller-supplied data-action. This is the idiomatic Stimulus wiring (an action binds the handler) and the only surface the Ruby suite can prove; the existing onSubmit class-field handler in form_controller.js is left unchanged (self-wiring in connect() would double-bind and fire onSubmit twice). ## Test Coverage - wires the submit handler via a data-action - preserves a caller-supplied data-action alongside the coordinator action ## Verification - [x] bundle exec rubocop lib spec passes - [x] bundle exec rspec passes Refs #11 * feat(components): checkbox_group verb for array-valued associations The batched "tag/facet picker" shape: a set of checkboxes sharing one array-valued field name (scope[name][]) with a leading empty-array hidden field, checked state derived from the model's current value matched by each item's resolved value:. Rendered under both themes. f.checkbox_group(:tag_ids, Tag.all, value: :id, label: :name, variant: :pill, size: :sm) f.field :tag_ids, as: :checkbox_group, collection: Tag.all, value: :id, label: :name - Forms::CheckboxGroup delegates each box's markup to DaisyUI::Checkbox so the size modifier resolves to a literal, scanner-visible class; the pill variant styles the active chip via Tailwind has-[:checked]: (no JS). - Forms::Plain::CheckboxGroup inherits the binding contract and overrides only the rendering seams — bare inputs, zero styling, aria-invalid on the group. - Field#checkbox_group owns the model binding (value:/label: as Symbol or Proc); Form#checkbox_group + render_field_input dispatch + the :checkbox_group theme role in both maps give full parity with select/tag_field. ## Test Coverage - shared array name across every checkbox + empty-array hidden field - checked set derived from the model (value 1,3 checked; 2 not) - option id from field id + value; label: proc with slug fallback - label HTML-escaped (no injection); size: maps to checkbox-sm - field inference (as: :checkbox_group); plain-theme parity (zero classes) - :checkbox_group role mapped in both Theme.daisy and Theme.plain ## Verification - [x] bundle exec rubocop lib spec passes - [x] bundle exec rspec passes Refs #9

Uh oh!

Bug: fields_for iterates a Hash-backed association (JSONB), emitting bogus indices #10

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions