Improve or squelch error message: proxy 9 received an unexpected message: message(caf::sec::broken_promise)

[awelzel]

This message has been observed and reported by users regularly as being produced on stderr. It's not obvious what it means or what one should do about it.

Could we be clearer about it, or if it's just an internal detail, not report it so loudly? One particular confusing part is the mentioning of "proxy" which likely has nothing nothing to do with the proxy nodes in a Zeek cluster, adding to the confusion.

broker/ERROR] 2023-03-26T13:24:16.456 proxy 9 received an unexpected message: message(caf::sec::broken_promise)

First link is the most recent occurrence with Zeek 5.2.0, then a few more in Slack. I know that @keithjjones has reported this in the past, too.

https://community.zeek.org/t/zeek-not-capturing-after-upgrade-to-5-2-0/6948/3
https://zeekorg.slack.com/archives/CSZBXF6TH/p1673386963146619
https://zeekorg.slack.com/archives/CSZBXF6TH/p1671739050030679?thread_ts=1671641522.937659&cid=CSZBXF6TH
https://zeekorg.slack.com/archives/CSZBXF6TH/p1658292150537879

[Neverlord]

It's not obvious what it means or what one should do about it.

This is a programming error, so there's nothing users can do about it except reporting it. I'll look into it.

Could we be clearer about it

Yeah, that message refers to a proxy for Broker data store object. I'll see what other errors Broker might report and try to improve the wording.