Skip to content

ci: book_rpc_reference snapshot is stale on main (missing z_exportviewingkey) #655

Description

@pacu

main is red. The book_rpc_reference_is_current test (added in #627) fails:

book/src/rpc/methods.md does not match the rustdoc on the RPC traits;
regenerate it with `ZALLET_BLESS=1 cargo test -p zallet-core --test book_rpc_reference`

Cause: z_exportviewingkey (added by #461) merged to main after #627's branch point. #627 generated the committed snapshot from the older main and merged cleanly (different files, no textual conflict), so the snapshot landed stale. The pinning test now fails on main, and on every open PR whose CI merges main (e.g. #631, which only adds a book page).

Fix: regenerate book/src/rpc/methods.md (ZALLET_BLESS=1); the diff is purely the added z_exportviewingkey section.

Prevention (follow-up): this is the snapshot form of a semantic (non-textual) merge conflict. Consider generating methods.md into OUT_DIR and comparing there so there is no committed artifact to go stale, or requiring the regen to accompany any RPC-doc change.


Filed with AI assistance (Claude).

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-documentationArea: DocumentationA-testingArea: Tests and testing infrastructureC-bugCategory: This is a bug

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions