-
-
Notifications
You must be signed in to change notification settings - Fork 311
Refactor pack create and setup orchestration #1277
Copy link
Copy link
Closed
Labels
cliCLI commands / dispatchCLI commands / dispatchenhancementNew feature or requestNew feature or requestpriority: lowNice to haveNice to havestatus: integratedFix merged to main but NOT yet in a tagged releaseFix merged to main but NOT yet in a tagged release
Milestone
Description
Metadata
Metadata
Assignees
Labels
cliCLI commands / dispatchCLI commands / dispatchenhancementNew feature or requestNew feature or requestpriority: lowNice to haveNice to havestatus: integratedFix merged to main but NOT yet in a tagged releaseFix merged to main but NOT yet in a tagged release
Summary
The code review found two high-complexity CLI/setup paths that are hard to maintain:
cmd_pack_createmixes argument parsing, validation, package building, registry installation, and reporting.run_setup_with_optionsorchestrates many setup side effects in one large function.Proposed change
Refactor these paths into smaller helpers without changing behavior:
PackCreateArgsandparse_pack_create_argsfromcmd_pack_create.Validation
rustfmt --edition 2024 --check rust/src/cli/pack_cmd.rs rust/src/setup/mod.rsgit diff --check -- rust/src/cli/pack_cmd.rs rust/src/setup/mod.rs