-
-
Notifications
You must be signed in to change notification settings - Fork 311
Refactor setup engine into smaller phases #1276
Copy link
Copy link
Closed
Labels
cliCLI commands / dispatchCLI commands / dispatchenhancementNew feature or requestNew feature or requestpriority: lowNice to haveNice to havestatus: integratedFix merged to main but NOT yet in a tagged releaseFix merged to main but NOT yet in a tagged release
Description
Metadata
Metadata
Assignees
Labels
cliCLI commands / dispatchCLI commands / dispatchenhancementNew feature or requestNew feature or requestpriority: lowNice to haveNice to havestatus: integratedFix merged to main but NOT yet in a tagged releaseFix merged to main but NOT yet in a tagged release
Problem
run_setup_with_optionshas grown into a large setup engine that mixes orchestration with shell hook setup, daemon setup, editor configuration, rules injection, skill installation, proxy setup, doctor checks, indexing, and report persistence. That makes the setup flow harder to review and maintain because each phase is embedded in one long function.Proposed change
Refactor the setup engine conservatively by keeping
run_setup_with_optionsas the orchestrator and moving each phase into private helper functions. Preserve the existing execution order, report wording, and side effects.Validation
rustfmt --check src/setup/mod.rsgit diff --check -- rust/src/setup/mod.rsrust/src/setup/mod.rs: no errors