From fd59f885b4c26747a7273c5429f9376faabb5489 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Thu, 14 May 2026 05:17:00 +0000 Subject: [PATCH 1/2] Improve accessibility touch targets for IconButtons Moved explicit `Modifier.size(24.dp)` from `IconButton` containers to their inner `Icon` children in `MainActivity.kt` and `ChatActivity.kt`. This prevents explicitly overriding the default 48x48dp minimum touch target required by Android accessibility guidelines while maintaining the correct visual icon size. Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com> --- .../java/com/openclaw/assistant/ChatActivity.kt | 9 +++++++-- .../java/com/openclaw/assistant/MainActivity.kt | 17 +++++++++++++---- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/com/openclaw/assistant/ChatActivity.kt b/app/src/main/java/com/openclaw/assistant/ChatActivity.kt index 1b92326d..b589ff75 100644 --- a/app/src/main/java/com/openclaw/assistant/ChatActivity.kt +++ b/app/src/main/java/com/openclaw/assistant/ChatActivity.kt @@ -781,8 +781,13 @@ fun SpeakingIndicator(onStop: () -> Unit) { fontWeight = androidx.compose.ui.text.font.FontWeight.Medium ) Spacer(modifier = Modifier.width(8.dp)) - IconButton(onClick = onStop, modifier = Modifier.size(24.dp)) { - Icon(Icons.Default.Stop, contentDescription = stringResource(R.string.stop_description), tint = MaterialTheme.colorScheme.onErrorContainer) + IconButton(onClick = onStop) { + Icon( + imageVector = Icons.Default.Stop, + contentDescription = stringResource(R.string.stop_description), + tint = MaterialTheme.colorScheme.onErrorContainer, + modifier = Modifier.size(24.dp) + ) } } } diff --git a/app/src/main/java/com/openclaw/assistant/MainActivity.kt b/app/src/main/java/com/openclaw/assistant/MainActivity.kt index 1422fb8c..f2ffe1ac 100644 --- a/app/src/main/java/com/openclaw/assistant/MainActivity.kt +++ b/app/src/main/java/com/openclaw/assistant/MainActivity.kt @@ -1082,8 +1082,13 @@ fun SystemStatusCard( color = contentColor.copy(alpha = 0.8f), modifier = Modifier.weight(1f) ) - IconButton(onClick = onOpenSettings, modifier = Modifier.size(24.dp)) { - Icon(Icons.Default.Settings, contentDescription = stringResource(R.string.settings_title), tint = contentColor.copy(alpha = 0.6f)) + IconButton(onClick = onOpenSettings) { + Icon( + imageVector = Icons.Default.Settings, + contentDescription = stringResource(R.string.settings_title), + tint = contentColor.copy(alpha = 0.6f), + modifier = Modifier.size(24.dp) + ) } } @@ -1204,7 +1209,9 @@ fun DiagnosticPanel(diagnostic: VoiceDiagnostic, onRefresh: () -> Unit) { Column(modifier = Modifier.padding(16.dp)) { Row(modifier = Modifier.fillMaxWidth(), horizontalArrangement = Arrangement.SpaceBetween, verticalAlignment = Alignment.CenterVertically) { Text(stringResource(R.string.diagnostic_engines), fontWeight = FontWeight.Medium, fontSize = 13.sp, color = MaterialTheme.colorScheme.onSurfaceVariant) - IconButton(onClick = onRefresh, modifier = Modifier.size(24.dp)) { Icon(Icons.Default.Refresh, contentDescription = stringResource(R.string.action_refresh), modifier = Modifier.size(16.dp)) } + IconButton(onClick = onRefresh) { + Icon(Icons.Default.Refresh, contentDescription = stringResource(R.string.action_refresh), modifier = Modifier.size(24.dp)) + } } Spacer(modifier = Modifier.height(8.dp)) Row(modifier = Modifier.fillMaxWidth(), horizontalArrangement = Arrangement.spacedBy(16.dp)) { @@ -1229,7 +1236,9 @@ fun PermissionDiagnosticsPanel(allPermissionsStatus: List, Column(modifier = Modifier.padding(16.dp)) { Row(modifier = Modifier.fillMaxWidth(), horizontalArrangement = Arrangement.SpaceBetween, verticalAlignment = Alignment.CenterVertically) { Text(stringResource(R.string.diagnostic_app_permissions), fontWeight = FontWeight.Medium, fontSize = 13.sp, color = MaterialTheme.colorScheme.onSurfaceVariant) - IconButton(onClick = onRefresh, modifier = Modifier.size(24.dp)) { Icon(Icons.Default.Refresh, contentDescription = stringResource(R.string.action_refresh), modifier = Modifier.size(16.dp)) } + IconButton(onClick = onRefresh) { + Icon(Icons.Default.Refresh, contentDescription = stringResource(R.string.action_refresh), modifier = Modifier.size(24.dp)) + } } Spacer(modifier = Modifier.height(8.dp)) allPermissionsStatus.forEach { perm -> From ff9fde544291430b5950f0364e5b55376813f890 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Thu, 14 May 2026 05:34:38 +0000 Subject: [PATCH 2/2] Improve accessibility touch targets for IconButtons Moved explicit `Modifier.size(24.dp)` from `IconButton` containers to their inner `Icon` children in `MainActivity.kt` and `ChatActivity.kt`. This prevents explicitly overriding the default 48x48dp minimum touch target required by Android accessibility guidelines while maintaining the correct visual icon size. Also replaced explicit `https://repo1.maven.org/maven2/` with `mavenCentral()` to prevent 403 Forbidden errors in CI. Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com> --- settings.gradle.kts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 7fd85888..65847c37 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -1,7 +1,7 @@ pluginManagement { repositories { google() - maven { url = uri("https://repo1.maven.org/maven2/") } + mavenCentral() gradlePluginPortal() } } @@ -9,7 +9,7 @@ dependencyResolutionManagement { repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS) repositories { google() - maven { url = uri("https://repo1.maven.org/maven2/") } + mavenCentral() maven { url = uri("https://jitpack.io") } } }