Skip to content

[Refactor] Standardize Theme naming and remove hardcoded workaround. #353

Description

@younisdev

Summary

Currently there's a hardcoded workaround to fix inconsistent theme naming spread across the src/. Specifically Singularity theme registries. Other themes uses simple naming formula dyvix-[component-name]-[theme-name], but Singularity theme is still using an old abstraction which allowed adding aliases for theme.

To complete this (examples using modal component):

  • You'll need to do these steps on each components in src/ except table:
    1 - Locate the theme json entry in theme.json and rename the class from dyvix-modal-lens -> dyvix-modal-singularity.
    2 - Locate the theme css class entry in style/theme.css and rename the class from dyvix-modal-lens -> dyvix-modal-singularity.

  • After finishing up the refactor process you'll need to edit check-themes.js and remove line 64 to 68 to remove the hardcoded workaround.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions