[Feature] Add `Obsidian` button theme

[younisdev]

Summary

Recently Obsidian theme got introduced in #336 by @shrutig-blip. This issue aims to port the global Obsidian theme to the button theme registry.

To achieve this, you need to:

1. Add the theme entry in themes.json file referencing the CSS classes of the new theme.
2. Add your CSS classes in themes.css.

Additional Information:

• Check out modal registry for examples of the Obsidian theme:

  • modal themes.json.
  • modal themes.css.

• To test your changes:
  1 - Run

  npm install
  npm run dev

  2 - Add your theme name in the devbench button.jsx.

[shrutig-blip]

Hi @younisdev! I'd like to work on this issue. Since I recently added the Obsidian modal theme in #336, I'd be happy to port the Obsidian theme to the button theme registry as well.

[shrutig-blip]

Hi! I implemented the Obsidian button theme and ran npm run dyvix:build. While testing in the devbench, I noticed that DYVIX_GLOBAL_THEME is generated only from src/components/modal/dependencies/themes.json, so the new button theme isn't added to src/constants.js. As a result, using theme="Obsidian" triggers "Please provide a valid theme." Is there another intended way to test button-specific themes, or should the build script also include button themes?

[younisdev]

Hi! I implemented the Obsidian button theme and ran npm run dyvix:build. While testing in the devbench, I noticed that DYVIX_GLOBAL_THEME is generated only from src/components/modal/dependencies/themes.json, so the new button theme isn't added to src/constants.js. As a result, using theme="Obsidian" triggers "Please provide a valid theme." Is there another intended way to test button-specific themes, or should the build script also include button themes?

Hey @shrutig-blip! Great catch, but don't worry about the build script the generator is just a parser that generates the theme constants for all components by transforming the theme definitions into strings, so it doesn't affect runtime functionality. You can either reuse the constant or simply use theme="Obsidian". I suspect that the issue you're seeing might be fixed by a hard refresh. Let me know if that fixes it.