Hi! This is super cool, thank you for making it -- I just ran examples/single_images.py, and stuff ran pretty smoothly :-)
I noticed that in _types.py you're using jax.core.canonicalize_shape (
|
self.shape = canonicalize_shape(shape) |
), but this has been deprecated/removed in recent jax versions (
https://github.com/google/jax/blob/60cc0411330d5c3652fe5eb8455408e7abf65912/CHANGELOG.md?plain=1#L80).
Is the canonicalize_shape call necessary? If so, maybe a note pinning the jax version could be helpful.
Hi! This is super cool, thank you for making it -- I just ran
examples/single_images.py, and stuff ran pretty smoothly :-)I noticed that in
_types.pyyou're usingjax.core.canonicalize_shape(jaxsplat/jaxsplat/_types.py
Line 15 in 502a10d
Is the
canonicalize_shapecall necessary? If so, maybe a note pinning the jax version could be helpful.