[FEAT] Folia support

[Mooling0602]

It seems this plugin doesn't support folia, any plans for it?

[xCykrix]

Hey @Mooling0602. I didn't yet have a plan for this but if you are interested I can look into supporting this. Foila is quite different so I may have to publish and maintain a version specifically for their API.

Let me research into it and follow up here.

[Mooling0602]

Hey @Mooling0602. I didn't yet have a plan for this but if you are interested I can look into supporting this. Foila is quite different so I may have to publish and maintain a version specifically for their API.

Let me research into it and follow up here.

That would be pretty nice, thanks a lot!

[HydrolienF]

Hi @xCykrix I would like to try to add Folia support. But I can't build the project

> Task :compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not resolve github.xCykrix:spigotdevkit:1.1.0-CAPI1.20.
     Required by:
         root project 'DynamicLights'
      > Could not resolve github.xCykrix:spigotdevkit:1.1.0-CAPI1.20.
         > Could not get resource 'https://maven.pkg.github.com/xCykrix/SpigotDevkit/github/xCykrix/spigotdevkit/1.1.0-CAPI1.20/spigotdevkit-1.1.0-CAPI1.20.pom'.
            > Could not GET 'https://maven.pkg.github.com/xCykrix/SpigotDevkit/github/xCykrix/spigotdevkit/1.1.0-CAPI1.20/spigotdevkit-1.1.0-CAPI1.20.pom'. Received status code 401 from server: Unauthorized

[HydrolienF]

I found a way to use the dependency as a local dependency by fixing Gradle version to the latest 8.x.x version and changing version string
Then I did some changes to support Folia and real server side light that melt snow in this branch. Feel free to use any of that code to support Folia in the main version.

The main idea is that each time you need to edit or read the world, you need to do it in a region scheduler.
And you can't access far away locations from a Region scheduler, so looping over each player whena light have been updated is not an option. however, with a real light block, the server will send the block update to all other players.

[xCykrix]

I do plan to take a look a bit further. I avoided using real light blocks on the very off minimal chance it places it somewhere it shouldn't have, eg: a chest spot. Packet lighting is just a far safer UX with known caveats.

[HydrolienF]

Ok, I can understand that.
Well if you do choose to make real server side light, you can easily check if the current player head location can be replaced by a light or not by checking if Material is AIR, else it should not be replace.

[HydrolienF]

I've made an 1.21.11 Folia compatible version in this fork. Feel free to use any of the code we edited if it help you supporting Folia or real light sources.

ps: You probably want to have JACK_O_LANTERN as a light source in the default config.

[xCykrix]

I've made an 1.21.11 Folia compatible version in this fork. Feel free to use any of the code we edited if it help you supporting Folia or real light sources.

ps: You probably want to have JACK_O_LANTERN as a light source in the default config.

I'll take a look. Ty! Also I did totally miss the Jack O' Lantern, oopsies.

[xCykrix]

I also missed End Rods and a few others apparently, what in the heck was I doing back then. Next update will have added defaults.