Move each app onto its own private keychain access group#25650
Draft
crazytonyli wants to merge 4 commits into
Draft
Move each app onto its own private keychain access group#25650crazytonyli wants to merge 4 commits into
crazytonyli wants to merge 4 commits into
Conversation
This was referenced Jun 12, 2026
Collaborator
Generated by 🚫 Danger |
7b06740 to
8dd9836
Compare
1502928 to
f98dbbd
Compare
f98dbbd to
bb8e1ec
Compare
8dd9836 to
b5d91e0
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32588 | |
| Version | PR #25650 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 89dec53 | |
| Installation URL | 5buhg4bhnjdmo |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32588 | |
| Version | PR #25650 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 89dec53 | |
| Installation URL | 6tt5g7qm5g2co |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
bb8e1ec to
89dec53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Last of a three-PR stack, on top of #25649. This is the PR that changes runtime behavior.
Description
3TMU3BH3NK.org.wordpress.wordpress,.jetpack,.reader), listed first in the entitlements so it becomes the default write target; the legacy shared group stays second for the migration contract. The Jetpack share, draft action, and notification service extension targets get their own entitlements files, since they previously reused the WordPress ones.KeychainGroupMigratorruns at launch in both apps: a one-time copy of existing items into the private group, then the coordinated sweep of the shared group once both apps have copied.Two transition tradeoffs are deliberate and documented in the code:
No Apple Developer portal or provisioning changes are needed: the profiles grant
keychain-access-groupsas a team-prefix wildcard, which covers the new groups.Testing instructions
Device only, the simulator ignores keychain access groups: