Unaccessible dirs lack output

[woosting]

When a directory can not be found the feedback output will always be [d] (not a directory).

This is minor as the check itself comes to the right conclusion: NOK. However, this should be solved as users will now have a much harder time to figure out what directory exactly is failing to correct it (sure they can figure it out by the chronology of the report.. but we should facilitate them where we can from a usability point of view).

@Sm0ke0ut do you have any idea's on this one (could it have something to do with the readlink function?

[woosting]

The trigger of the issue is not that the directory itself may not exist/be a directory.

It is about a path "hop" failing:

user@bash:~/dev$ dirp -r /tmp/foo
[d] /tmp/foo (not a directory)
FAILED: some directories verified NOK!
user@bash:~/dev$ dirp -r /notexisting/foo
[d] (not a directory)
FAILED: some directories verified NOK!

So the dir can not be found (and probably a variable does not get filled).

[woosting]

@Sm0ke0ut do you have any idea's on this one (could it have something to do with the readlink function?

After some testing I am pretty sure it does, pre directory=$(readlink -f ${directory}) the variable ${directory} is still filled, post directory=$(readlink -f ${directory}) it is not anymore.

See/test: the following code.

[woosting]

Looking at the man page of readlink it seems that setting the -m flag would be more appropriate. Ergo making it: directory=$(readlink -m ${directory})

I tested it to resolve this issue, but does it pose a functional issue elsewhere on system level (as it is less strict than the -f variant of readlink that was previously used)?

@Sm0ke0ut could you verify - or, more importantly, validate - this fix (the code containing the fix is located in the test branch)?