Skip to content

Commit d70db64

Browse files
committed
Address review: ASCII ellipsis and restore TlsCheckCookie doc comment
Replace the U+2026 ellipsis in the wolfSSL_DTLS_SetCookieSecretSecondary doxygen example with ASCII '...' to match the DTLS 1.3 sibling block. Move the TlsCheckCookie doc comment back to directly precede TlsCheckCookie; the cookie MAC refactor had left it stacked above TlsCheckCookieMac.
1 parent 923263d commit d70db64

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

doc/dox_comments/header_files/ssl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8964,7 +8964,7 @@ int wolfSSL_DTLS_SetCookieSecret(WOLFSSL* ssl,
89648964
WOLFSSL* ssl = wolfSSL_new(ctx);
89658965
const byte* oldSecret;
89668966
word32 oldSecretSz; // size of oldSecret
8967-
8967+
...
89688968
if(wolfSSL_DTLS_SetCookieSecretSecondary(ssl, oldSecret, oldSecretSz) != 0){
89698969
// Code block for failure to set secondary DTLS cookie secret
89708970
} else {

src/tls13.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7066,13 +7066,6 @@ static int CheckPreSharedKeys(WOLFSSL* ssl, const byte* input, word32 helloSz,
70667066
#endif /* HAVE_SESSION_TICKET || !NO_PSK */
70677067

70687068
#if defined(WOLFSSL_SEND_HRR_COOKIE)
7069-
/* Check that the Cookie data's integrity.
7070-
*
7071-
* ssl SSL/TLS object.
7072-
* cookie The cookie data - hash and MAC.
7073-
* cookieSz The length of the cookie data in bytes.
7074-
* returns Length of the hash on success, otherwise failure.
7075-
*/
70767069
/* Compute the cookie integrity HMAC over the cookie data (and, for DTLS, the
70777070
* peer address) using the given secret and compare it in constant time against
70787071
* the MAC trailing the cookie.
@@ -7127,6 +7120,13 @@ static int TlsCheckCookieMac(const WOLFSSL* ssl, const byte* cookie,
71277120
return 0;
71287121
}
71297122

7123+
/* Check that the Cookie data's integrity.
7124+
*
7125+
* ssl SSL/TLS object.
7126+
* cookie The cookie data - hash and MAC.
7127+
* cookieSz The length of the cookie data in bytes.
7128+
* returns Length of the hash on success, otherwise failure.
7129+
*/
71307130
int TlsCheckCookie(const WOLFSSL* ssl, const byte* cookie, word16 cookieSz)
71317131
{
71327132
int ret;

0 commit comments

Comments
 (0)