From d39465e5d28b628117d403db3ee7a096b628a484 Mon Sep 17 00:00:00 2001 From: Yosuke Shimizu Date: Tue, 24 Mar 2026 14:24:29 +0900 Subject: [PATCH 1/4] Fix toupper usage --- src/ecparam/clu_ecparam.c | 2 +- src/genkey/clu_genkey_setup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ecparam/clu_ecparam.c b/src/ecparam/clu_ecparam.c index e7657fe8..078e3e6d 100644 --- a/src/ecparam/clu_ecparam.c +++ b/src/ecparam/clu_ecparam.c @@ -154,7 +154,7 @@ int wolfCLU_ecparam(int argc, char** argv) /* convert name to upper case */ for (i = 0; i < (int)XSTRLEN(name); i++) - (void)toupper(name[i]); + name[i] = toupper(name[i]); #if 0 /* way to get the key size if needed in the future */ diff --git a/src/genkey/clu_genkey_setup.c b/src/genkey/clu_genkey_setup.c index 47fecc5b..72ca19ae 100644 --- a/src/genkey/clu_genkey_setup.c +++ b/src/genkey/clu_genkey_setup.c @@ -165,7 +165,7 @@ int wolfCLU_genKeySetup(int argc, char** argv) /* convert name to upper case */ for (i = 0; i < (int)XSTRLEN(name); i++) - (void)toupper(name[i]); + name[i] = toupper(name[i]); } } From f0f6b689ab20bbcd86b921e2ebf9e7ee900e6504 Mon Sep 17 00:00:00 2001 From: Yosuke Shimizu Date: Tue, 24 Mar 2026 14:41:54 +0900 Subject: [PATCH 2/4] Fix f_643 --- src/genkey/clu_genkey_setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/genkey/clu_genkey_setup.c b/src/genkey/clu_genkey_setup.c index 72ca19ae..c205221f 100644 --- a/src/genkey/clu_genkey_setup.c +++ b/src/genkey/clu_genkey_setup.c @@ -509,7 +509,7 @@ int wolfCLU_genKeySetup(int argc, char** argv) XMEMCPY(xmssmtParam + xmssmtHeadLen, "60/3_256\0", hdLen); } else if (XSTRNCMP(argv[ret+1], "6", 1) == 0) { - XMEMCPY(xmssmtParam + xmssmtHeadLen, "60/8_256\0", hdLen); + XMEMCPY(xmssmtParam + xmssmtHeadLen, "60/6_256\0", hdLen); } else if (XSTRNCMP(argv[ret+1], "12", 2) == 0) { XMEMCPY(xmssmtParam + xmssmtHeadLen, "60/12_256\0", hdLen+1); From 237d10a628b4b92a903476895491a05902992bf6 Mon Sep 17 00:00:00 2001 From: Yosuke Shimizu Date: Tue, 24 Mar 2026 14:43:23 +0900 Subject: [PATCH 3/4] Fix f_642 --- src/genkey/clu_genkey_setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/genkey/clu_genkey_setup.c b/src/genkey/clu_genkey_setup.c index c205221f..79d0e789 100644 --- a/src/genkey/clu_genkey_setup.c +++ b/src/genkey/clu_genkey_setup.c @@ -501,7 +501,7 @@ int wolfCLU_genKeySetup(int argc, char** argv) } else { WOLFCLU_LOG(WOLFCLU_L0, "Invalid -layer (%s), using 2", argv[ret+1]); - XMEMCPY(xmssmtParam + xmssmtHeadLen, "40/2_25\0", hdLen); + XMEMCPY(xmssmtParam + xmssmtHeadLen, "40/2_256\0", hdLen); } break; case 60: From 2e4f176eea2c8b5dd11be99d3adec255fcd628c5 Mon Sep 17 00:00:00 2001 From: Yosuke Shimizu Date: Tue, 24 Mar 2026 15:36:32 +0900 Subject: [PATCH 4/4] Add the cast to unsigned char --- src/ecparam/clu_ecparam.c | 2 +- src/genkey/clu_genkey_setup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ecparam/clu_ecparam.c b/src/ecparam/clu_ecparam.c index 078e3e6d..a644ea4a 100644 --- a/src/ecparam/clu_ecparam.c +++ b/src/ecparam/clu_ecparam.c @@ -154,7 +154,7 @@ int wolfCLU_ecparam(int argc, char** argv) /* convert name to upper case */ for (i = 0; i < (int)XSTRLEN(name); i++) - name[i] = toupper(name[i]); + name[i] = (char)toupper((unsigned char)name[i]); #if 0 /* way to get the key size if needed in the future */ diff --git a/src/genkey/clu_genkey_setup.c b/src/genkey/clu_genkey_setup.c index 79d0e789..a104c05a 100644 --- a/src/genkey/clu_genkey_setup.c +++ b/src/genkey/clu_genkey_setup.c @@ -165,7 +165,7 @@ int wolfCLU_genKeySetup(int argc, char** argv) /* convert name to upper case */ for (i = 0; i < (int)XSTRLEN(name); i++) - name[i] = toupper(name[i]); + name[i] = (char)toupper((unsigned char)name[i]); } }