fix: add missing favicon link to page-4.html#1
Open
borice1984 wants to merge 1 commit into
Open
Conversation
All other pages in the static template include a favicon link tag; page-4.html was the only page missing it, causing a 404 on every page load when deployed to S3 or any static host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing
<link rel="icon">tag topage-4.html.Why
Every other page in the static template includes a favicon link tag.
page-4.htmlwas the only one missing it, which causes a 404 request for/favicon.svgon every load of that page when deployed to S3 or any static host.Change
One line added to
<head>, consistent with all other pages.