diff --git a/kawala-common-tests/pom.xml b/kawala-common-tests/pom.xml index 396b0b1..925ecd3 100644 --- a/kawala-common-tests/pom.xml +++ b/kawala-common-tests/pom.xml @@ -28,19 +28,19 @@ com.kaching.platform kawala-common - 0.1.6-SNAPSHOT + ${project.version} test com.kaching.platform kawala-converters - 0.1.6-SNAPSHOT + ${project.version} test com.kaching.platform kawala-testing - 0.1.6-SNAPSHOT + ${project.version} test diff --git a/kawala-converters/pom.xml b/kawala-converters/pom.xml index e69ae95..c02d857 100644 --- a/kawala-converters/pom.xml +++ b/kawala-converters/pom.xml @@ -44,12 +44,12 @@ com.kaching.platform kawala-common - 0.1.6-SNAPSHOT + ${project.version} com.kaching.platform kawala-guice - 0.1.6-SNAPSHOT + ${project.version} asm diff --git a/kawala-converters/src/test/java/com/kaching/platform/converters/InstantiatorErrorsTest.java b/kawala-converters/src/test/java/com/kaching/platform/converters/InstantiatorErrorsTest.java index 01c6b3f..65359ae 100644 --- a/kawala-converters/src/test/java/com/kaching/platform/converters/InstantiatorErrorsTest.java +++ b/kawala-converters/src/test/java/com/kaching/platform/converters/InstantiatorErrorsTest.java @@ -12,6 +12,7 @@ import static com.kaching.platform.converters.InstantiatorErrors.noSuchField; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; import java.util.List; @@ -95,8 +96,7 @@ public void addinTwiceTheSameMessageDoesNotDuplicateTheError() { @Test public void cannotSpecifyDefaultValueAndConstant() throws Exception { check( - "cannot specify both a default constant and a default value " + - "@Optional(constant=FOO, value=4)", + "cannot specify both a default constant and a default value ", InstantiatorErrors.cannotSpecifyDefaultValueAndConstant( new Errors(), inspectMeCannotSpecifyDefaultValueAndConstant(8))); } @@ -122,7 +122,7 @@ private void check(String expected, Errors errors) { errors.throwIfHasErrors(); fail(); } catch (RuntimeException e) { - assertEquals("1) " + expected, e.getMessage()); + assertTrue(e.getMessage(), e.getMessage().startsWith("1) " + expected)); } } diff --git a/kawala-guice/pom.xml b/kawala-guice/pom.xml index 5356a9d..35635cf 100644 --- a/kawala-guice/pom.xml +++ b/kawala-guice/pom.xml @@ -43,12 +43,12 @@ com.kaching.platform kawala-common - 0.1.6-SNAPSHOT + ${project.version} com.kaching.platform kawala-testing - 0.1.6-SNAPSHOT + ${project.version} test diff --git a/kawala-hibernate/pom.xml b/kawala-hibernate/pom.xml index 72b2f2b..e706f60 100644 --- a/kawala-hibernate/pom.xml +++ b/kawala-hibernate/pom.xml @@ -44,12 +44,12 @@ com.kaching.platform kawala-common - 0.1.6-SNAPSHOT + ${project.version} com.kaching.platform kawala-converters - 0.1.6-SNAPSHOT + ${project.version} org.hibernate diff --git a/kawala-testing/pom.xml b/kawala-testing/pom.xml index 428ce69..693a6b3 100644 --- a/kawala-testing/pom.xml +++ b/kawala-testing/pom.xml @@ -48,7 +48,7 @@ com.kaching.platform kawala-common - 0.1.6-SNAPSHOT + ${project.version} jdepend diff --git a/kawala-testing/src/test/java/com/kaching/platform/testing/CyclicDependencyTestRunnerTest.java b/kawala-testing/src/test/java/com/kaching/platform/testing/CyclicDependencyTestRunnerTest.java index e53dacf..ec4a251 100644 --- a/kawala-testing/src/test/java/com/kaching/platform/testing/CyclicDependencyTestRunnerTest.java +++ b/kawala-testing/src/test/java/com/kaching/platform/testing/CyclicDependencyTestRunnerTest.java @@ -14,7 +14,9 @@ import static org.junit.Assert.assertTrue; import java.io.IOException; +import java.util.Set; +import jdepend.framework.JavaPackage; import org.junit.Test; import com.kaching.platform.testing.CyclicDependencyTestRunner.Packages; @@ -76,11 +78,13 @@ public void testBasePackage_Cycles() throws IOException { Result result = runner.getTestResults(BasePackage.class.getAnnotation(Packages.class)); assertTrue(result.numClasses > 0); assertEquals(1, result.getUniqueCycles().size()); - assertEquals("Strongly connected components: {\n" + - "[com.kaching.platform.testing.testexamples.a,\n" - + " com.kaching.platform.testing.testexamples.b,\n" - + " com.kaching.platform.testing.testexamples.c]\n" - + "}", result.toString()); + + Set packages = result.getUniqueCycles().iterator().next(); + + assertEquals(3, packages.size()); + assertTrue(packages.contains(new JavaPackage("com.kaching.platform.testing.testexamples.a"))); + assertTrue(packages.contains(new JavaPackage("com.kaching.platform.testing.testexamples.b"))); + assertTrue(packages.contains(new JavaPackage("com.kaching.platform.testing.testexamples.c"))); } } diff --git a/kawala-testing/src/test/java/com/kaching/platform/testing/DependencyTestRunnerTest.java b/kawala-testing/src/test/java/com/kaching/platform/testing/DependencyTestRunnerTest.java index 7f25165..94c711c 100644 --- a/kawala-testing/src/test/java/com/kaching/platform/testing/DependencyTestRunnerTest.java +++ b/kawala-testing/src/test/java/com/kaching/platform/testing/DependencyTestRunnerTest.java @@ -13,6 +13,7 @@ import static com.google.common.collect.Lists.newArrayList; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.fail; import jdepend.framework.JavaClass; import jdepend.framework.JavaPackage; @@ -183,11 +184,33 @@ public void violationToString() { classB.addImportedPackage(violation.efferent); violation.javaPackage.addClass(classB); - violation.javaPackage.addClass(new JavaClass("a.BigC")); + JavaClass classC = new JavaClass("a.BigC"); + violation.javaPackage.addClass(classC); + + String message = violation.toString(); + + String packageName = violation.javaPackage.getName(); + + assertTrue(message, message.contains("package a cannot depend on package b")); + assertTrue( + message, + message.contains( + classA.getName().substring(packageName.length() + 1) + ) + ); + assertTrue( + message, + message.contains( + classB.getName().substring(packageName.length() + 1) + ) + ); + assertFalse( + message, + message.contains( + classC.getName().substring(packageName.length() + 1) + ) + ); - assertEquals( - "package a cannot depend on package b (classes BigA, BigB)", - violation.toString()); } @Test