make_sdc_dm_environment() fails due to sim agents not matching the number of sim agents params

[the-big-bad-wolf]

Running
make_sdc_dm_environment(dynamics_model, data_loader_config, env_config)
results in
ValueError: Number of sim agents must match number of sim agent params

There is a bug in Waymax as make_sdc_dm_environment() doesn't supply parameters when creating the PlanningAgentEnvironment.

[samuela]

You need to pass parameters for each of your sim_agent_actors, eg

PlanningAgentEnvironment(..., sim_agent_actors=[actor1, actor2, actor3], sim_agent_params=[params1, params2, params3])

See

waymax/waymax/env/planning_agent_environment.py

Lines 205 to 208 in 48b33d7

	if len(self._sim_agent_actors) != len(self._sim_agent_params):
	raise ValueError(
	'Number of sim agents must match number of sim agent params.'
	)

for more info

[the-big-bad-wolf]

I know, I am saying that the DMEnv wrapper you provide is not doing this.

waymax/waymax/env/wrappers/dm_env_wrapper.py

Lines 217 to 221 in 48b33d7

	single_env = planning_agent_environment.PlanningAgentEnvironment(
	dynamics_model=dynamics_model,
	config=env_config,
	sim_agent_actors=sim_agent_actors,
	)

[samuela]

Oh, I see. Apologies for the confusion! Reopening