Cut foreground CLI and Zed over to AgentProfile transitions and application settings

[acoliver]

Parent: #2635

Objective

Cut the foreground CLI and Zed execution owner over to the transactional profile controller, including startup, /profile, /provider, /model, profile /set, application /settings, blank /setup, UI/session display settings, persistence conflicts, and checkpoint/restore.

This is the user-facing foreground vertical cut. It consumes the sibling schema/repository and controller/runtime foundations and deletes the foreground legacy path it replaces.

Scope

Startup and unconfigured state

• Compile startup flags into exactly one initial profile command, never Config precedence plus post-activation overrides.
• No profile/provider means explicit unconfigured state; configuration/list/setup commands work, model execution returns typed profile-required.
• --provider ... --model ... --key-name ... creates one blank provider-template document with explicit model/auth reference.
• Standard --profile-load + --model clones/patches the saved standard document directly.
• LB --profile-load + --model requires qualified --member; no active-member inference exists at startup.
• Failed initialization publishes no partial Agent.

Commands and UI

Route CLI and Zed through AgentProfile commands/queries/subscriptions only:

• /model: exact clone semantics, provider-specific immutable menu source, stale-menu handling.
• /provider: blank reset including same-provider case.
• /profile load/save/list/status/delete: exact load, qualified result display, etag conflicts, explicit overwrite/save-as, reverse-reference errors, stale identity, redacted requested/effective status.
• profile /set: profile-owned keys only; application keys return /settings guidance.
• /settings: independent application settings service with owner/propagation semantics.
• /setup: always blank; disposable credential/model tests; Cancel no-op; Finish one commit; optional build→persist→memory ordering.
• destructive replacement of an unsaved draft requires confirmation; headless adapters use discardUnsaved.
• commands while busy expose queued/busy/cancelled/stale states accurately.

UI/application ownership

• ui.showReasoning: persisted application default plus UI-session-only toggle/keybinding; streaming/rerender visibility changes without profile/runtime revision and Agent API keeps structured reasoning.
• emojifilter, dumpcontext, dumponerror: application-owned; visual effects may be immediate while enforcement is captured in turn/tool context.
• Service-reconfigure/restart-required settings use explicit paths; no generic mutable SettingsService consumption inside turns.
• Tool declarations/status are derived from current runtime policy without globally mutating tool registry.

Foreground lifecycle and continuity

• Commit only at execution-coordinator safe boundary.
• Preserve conversation/history, session ID, message bus, MCP/environment infrastructure, todos, task manager, checkpoints, and session metrics across profile changes.
• Replace profile-derived provider/model/settings/policy/LB runtime and rebind listeners/tool declarations.
• OAuth/failover hooks attach to the new runtime; GCP/provider config is threaded explicitly rather than process.env writes/read-back.
• Checkpoint/restore saves working identity plus explicit document (including draft), verifies saved etag, reconstructs runtime, and never serializes clients/secrets/tokens/LB cursor/runtime IDs.
• CLI and Zed share the same state path and differ only in interaction/rendering adapter.

Delete foreground legacy path

Remove or make unreachable for the foreground owner:

• synthetic profile-as-CLI-arguments and post-switch override reapplication;
• direct applyProfileWithGuards/applyProfileSnapshot activation/snapshot reads;
• direct provider/model/profile state reads through Config/runtime accessors;
• foreground profile process.env mutation/read-back;
• direct profile directory scans or provider mutation from UI/Zed;
• legacy currentProfile/activeProvider projection writes.

Do not leave old and new writers active for this owner.

Coordination / non-overlap

• Re-architect React/Ink UI state, dialogs, and subscriptions to remove projection plumbing #2536 owns broad React/Ink UI state refactoring; this task changes only profile/application-settings adapters required for Transactional per-agent profiles: replace ambient provider/model state with declarative runtime ownership #2635.
• Increase onboarding, profile, provider, and model UI coverage #2023 owns wider profile/provider/model UI coverage; add focused behavioral coverage here without absorbing unrelated UI work.
• Make lazy authentication cancellable and route subagent auth challenges through the interactive host #2562 owns interactive OAuth UI/cancellation; foreground provides the supervising host integration point only.
• Decompose the Config god-object: role interfaces, composition roots, service-locator elimination #2615/Eliminate ambient runtime global state: explicit dependency injection, delete getCliRuntimeServices and the singleton maze #2616 own broader Config/global cleanup; this task removes foreground dependencies needed by Transactional per-agent profiles: replace ambient provider/model state with declarative runtime ownership #2635.

Acceptance criteria

• Foreground CLI and Zed use only Agent profile commands/queries/subscriptions; no private profile store or direct provider mutation remains.
• Startup produces exactly one command and unconfigured behavior is explicit.
• Every command follows Transactional per-agent profiles: replace ambient provider/model state with declarative runtime ownership #2635 literal semantics, confirmation, stale, conflict, and redaction behavior.
• Profile changes preserve session/environment continuity while replacing only profile-derived runtime state at a safe boundary.
• Reasoning display toggle and application setting propagation do not mutate profile state or in-flight policy incorrectly.
• Checkpoint/restore preserves explicit saved/draft working state without serializing operational resources/secrets.
• Foreground legacy profile/snapshot/CLI-override/env/projection paths have no production callers for this owner.
• Focused CLI/Zed/setup/startup/settings/profile/LB/checkpoint tests plus full test/lint/typecheck/format/build and profile smoke verification pass.

[coderabbitai]

🔗 Related PRs

#1322 - Refactor profile application workflows into focused helpers [merged]
#1454 - Fix profile clear semantics for key/keyfile/base-url (Fixes #208) [merged]
#2064 - Avoid profile switch stalls after failed turns (Fixes #2049) [merged]
#2365 - Preserve keyfile profile auth in interactive startup (Fixes #2364) [merged]
#2390 - Drive provider activation and auth through agent config, not CLI orchestration (Fixes #2374) [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!