functor_invoke_thunk should return errors using Value::error_string

[4silvertooth]

Although I know it's very much WIP, do notice that method_thunk shouldn't return 0

rsciter/crates/rsciter/examples/global_asset.rs

Line 101 in b0fe1f4

return 0;

The body should be similar to functor_invoke_thunk

rsciter/crates/rsciter/src/value.rs

Line 567 in b0fe1f4

unsafe extern "C" fn functor_invoke_thunk(

*p_value must be either result or Value::error_string

member_function thunk here always returns TRUE
https://gitlab.com/sciter-engine/sciter-js-sdk/-/blob/main/include/sciter-om-def.h?ref_type=heads#L227

[vsrs]

@4silvertooth,

*p_value must be either result or Value::error_string

Not necessary. You can place your own error in p_value (Value::error_string as you correctly pointed out), but if you just return 0, the engine will generate the TypeError error on its own.

Here is the relevant sciter code (if you have a license, you can check engine\xdomjs\xasset.cpp,25 asset_method_magic_bound function):

      if (!md.func(pass, nargs, args.cbegin(), &rv))
        //throw qjs::om::type_error(string::format("method %s::%s",symbol_name_a(psp->name).c_str(), symbol_name_a(md.name).c_str()));
        return JS_ThrowTypeError(ctx, string::format("method %s::%s", hruntime::current().symbol_name_a(psp->name).c_str(), hruntime::current().symbol_name_a(md.name).c_str()));
      return conv<tool::value>::wrap(ctx, rv);

So returning 0 is a convinient way to report a method call error without details.

Anyway, thank you for your attention :) In the final code, I'll definitely construct the Value::error string first to provide a better error message.

[vsrs]

btw, just realized that functor_invoke_thunk

rsciter/crates/rsciter/src/value.rs

Lines 567 to 580 in b0fe1f4

	unsafe extern "C" fn functor_invoke_thunk(
	tag: *mut ::std::os::raw::c_void,
	argc: UINT,
	argv: *const VALUE,
	retval: *mut VALUE,
	) {
	let state = &mut *(tag as *mut FunctorState);
	let args = args_from_raw_parts(argv, argc);
	if let Some(res) = state.functor.invoke(args) {
	if !retval.is_null() {
	*retval = res.take();
	}
	}
	}

may report error via Value::error_string if state.functor.invoke(args) call fails. Thanks.