Skip to content

fix(sessions): crystallize summary omits approved GOAL proposals #741

Description

@kurosawareiji7007-hub

What happened

sessions._approved_artifact_ids_for_session only includes CLAIM/PAGE/ENTITY/RELATION when building the crystallize summary page. After first-class goals (#427), an approved GOAL filed in the session never appears under "Crystallized artifacts".

Expected

Approved goals in the session are listed like other create-kind artifacts. DELETE stays excluded.

Repro

sess = session_start(store, agent="a", task="t")
pr = propose_goal(store, title="ship", proposed_by="a", session_id=sess.id)
goal = approve(store, pr.id, approved_by="h")
session_end(store, sess.id)
page = get_page(crystallize(store, sess.id, approver="h")["summary_page_id"])
# goal.id missing from page.body today

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions