fix(list): exclude archived pages from filter_pages listings - #730
Closed
kurosawareiji7007-hub wants to merge 1 commit into
Closed
fix(list): exclude archived pages from filter_pages listings#730kurosawareiji7007-hub wants to merge 1 commit into
kurosawareiji7007-hub wants to merge 1 commit into
Conversation
kb.list_pages / vouch pages shared filter_pages with no ARCHIVED gate, so retired pages stayed in the agent live set (and MCP/CLI omit status). Default to live-set only; include_archived=True opts back in. Fixes vouchdev#728
github-actions
Bot
added
docs
Contributor
Author
|
Maintainer note: this is a correctness bugfix. If it looks right, a |
Contributor
Author
|
Closing to stay at the Gittensor open-PR threshold (max 3 on vouch). Fix remains on branch fix/list-pages-exclude-archived — happy to reopen after another PR merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_pages(shared by MCPkb.list_pages, JSONL, andvouch pages) had noPageStatus.ARCHIVEDgate, so archived pages stayed in the agent live listing.include_archived=Trueopts back in for callers that need the full set.Fixes #728
Test plan
uv run pytest tests/test_page_filters.py -q