follow ups

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Author: AdamGS

encodings/parquet-variant/Cargo.toml

@@ -12,7 +12,6 @@ readme = { workspace = true }
 repository = { workspace = true }
 rust-version = { workspace = true }
 version = { workspace = true }
-publish = true
 
 [lints]
 workspace = true
@@ -28,10 +27,10 @@ prost = { workspace = true }
 vortex-array = { workspace = true }
 vortex-buffer = { workspace = true }
 vortex-error = { workspace = true }
+vortex-json = { workspace = true, optional = true }
 vortex-mask = { workspace = true }
 vortex-proto = { workspace = true }
 vortex-session = { workspace = true }
-vortex-json = { workspace = true, optional = true }
 
 [dev-dependencies]
 rstest = { workspace = true }

vortex-btrblocks/Cargo.toml

@@ -48,7 +48,6 @@ vortex-zstd = { workspace = true, optional = true }
 
 [dev-dependencies]
 divan = { workspace = true }
-rand = { workspace = true }
 rstest = { workspace = true }
 test-with = { workspace = true }
 vortex-array = { workspace = true, features = ["_test-harness"] }
@@ -66,7 +65,6 @@ parquet-variant = [
     "dep:parquet-variant-compute",
     "dep:vortex-session",
     "dep:vortex-json",
-    "zstd",
 ]
 pco = ["dep:pco", "dep:vortex-pco"]
 zstd = ["dep:vortex-zstd"]

vortex-btrblocks/src/schemes/variant/json_to_variant.rs

@@ -36,11 +36,13 @@ mod parquet_variant_children {
     pub const METADATA: usize = 0;
     /// The raw Parquet Variant value child.
     pub const VALUE: usize = 1;
+    /// The raw Parquet Variant typed_value child.
+    pub const TYPED_VALUE: usize = 2;
 }
 
 impl Scheme for JsonToVariantScheme {
     fn scheme_name(&self) -> &'static str {
-        "json_to_variant"
+        "vortex.variant.pq.json"
     }
 
     fn matches(&self, canonical: &Canonical) -> bool {
@@ -109,14 +111,29 @@ impl Scheme for JsonToVariantScheme {
             })
             .transpose()?;
 
+        // This is currently always none, but we should make sure to compress it
+        // if it exists
+        let typed_value = parquet_variant
+            .typed_value_array()
+            .map(|typed| {
+                compressor.compress_child(
+                    typed,
+                    &compress_ctx,
+                    self.id(),
+                    parquet_variant_children::TYPED_VALUE,
+                    exec_ctx,
+                )
+            })
+            .transpose()?;
+
         let variant_validity = parquet_variant
             .validity()?
             .union_nullability(output_nullability);
         let variant = ParquetVariant::try_new(
             variant_validity,
             compressed_metadata,
             compressed_value,
-            parquet_variant.typed_value_array().cloned(),
+            typed_value,
         )?
         .into_array();
 

vortex-btrblocks/src/schemes/variant/tests.rs

@@ -302,7 +302,6 @@ fn prefers_smaller_extension_storage_over_variant_scheme() -> vortex_error::Vort
         &JsonToVariantScheme,
         &BinaryDictScheme,
         &BinaryFSSTScheme,
-        &binary::ZstdScheme,
         &IntConstantScheme,
         &StringConstantScheme,
         &FoRScheme,