coverage

Signed-off-by: Robert Kruszewski <github@robertk.io>

Author: robert3005

vortex-buffer/src/buffer.rs

@@ -763,6 +763,7 @@ impl<T> From<BufferMut<T>> for Buffer<T> {
 #[cfg(test)]
 mod test {
     use bytes::Buf;
+    use rstest::rstest;
 
     use crate::Alignment;
     use crate::Buffer;
@@ -831,12 +832,35 @@ mod test {
         const LEN: usize = 17;
         let alignment = Alignment::new(64);
 
-        let buf = Buffer::<u32>::zeroed_aligned(LEN, alignment, Some(Alignment::DEFAULT_ALIGNMENT));
+        let buf = Buffer::<u32>::zeroed_aligned(LEN, alignment);
 
         assert!(buf.is_aligned(alignment));
         assert_eq!(buf.as_slice(), &[0; LEN]);
     }
 
+    #[test]
+    fn copy_from_over_aligns_to_default() {
+        let values = [1u32, 2, 3];
+        let buf = Buffer::<u32>::copy_from(values);
+
+        // The buffer reports the scalar type's alignment, ...
+        assert_eq!(buf.alignment(), Alignment::of::<u32>());
+        // ... but the underlying allocation is over-aligned to DEFAULT_ALIGNMENT.
+        assert!(buf.is_aligned(Alignment::DEFAULT_ALIGNMENT));
+        assert_eq!(buf.as_slice(), &values);
+    }
+
+    #[test]
+    fn zeroed_over_aligns_to_default() {
+        const LEN: usize = 17;
+
+        let buf = Buffer::<u32>::zeroed(LEN);
+
+        assert_eq!(buf.alignment(), Alignment::of::<u32>());
+        assert!(buf.is_aligned(Alignment::DEFAULT_ALIGNMENT));
+        assert_eq!(buf.as_slice(), &[0; LEN]);
+    }
+
     #[test]
     fn from_vec() {
         let vec = vec![1, 2, 3, 4, 5];
@@ -855,11 +879,7 @@ mod test {
 
     #[test]
     fn empty_slice_preserves_alignment() {
-        let buf = Buffer::<u64>::zeroed_aligned(
-            8,
-            Alignment::new(64),
-            Some(Alignment::DEFAULT_ALIGNMENT),
-        );
+        let buf = Buffer::<u64>::zeroed_aligned(8, Alignment::new(64));
         let sliced = buf.slice(0..0);
         assert!(sliced.is_empty());
         assert_eq!(sliced.alignment(), Alignment::new(64));

vortex-buffer/src/buffer_mut.rs

@@ -161,7 +161,7 @@ impl<T> BufferMut<T> {
 
     /// Create a mutable scalar buffer by copying the contents of the slice.
     pub fn copy_from(other: impl AsRef<[T]>) -> Self {
-        Self::copy_from_aligned(other, Alignment::DEFAULT_ALIGNMENT)
+        Self::copy_from_aligned(other, Alignment::of::<T>())
     }
 
     /// Create a mutable scalar buffer with the alignment by copying the contents of the slice.