Skip to content

Commit b79f254

Browse files
committed
Uncycle dependencies
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
1 parent 71306c8 commit b79f254

1 file changed

Lines changed: 7 additions & 17 deletions

File tree

vortex-btrblocks/src/schemes/variant/json_to_variant.rs

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ mod parquet_variant_children {
3636
pub const METADATA: usize = 0;
3737
/// The raw Parquet Variant value child.
3838
pub const VALUE: usize = 1;
39-
/// The raw Parquet Variant typed_value child.
40-
pub const TYPED_VALUE: usize = 2;
4139
}
4240

4341
impl Scheme for JsonToVariantScheme {
@@ -111,20 +109,12 @@ impl Scheme for JsonToVariantScheme {
111109
})
112110
.transpose()?;
113111

114-
// This is currently always none, but we should make sure to compress it
115-
// if it exists
116-
let typed_value = parquet_variant
117-
.typed_value_array()
118-
.map(|typed| {
119-
compressor.compress_child(
120-
typed,
121-
&compress_ctx,
122-
self.id(),
123-
parquet_variant_children::TYPED_VALUE,
124-
exec_ctx,
125-
)
126-
})
127-
.transpose()?;
112+
// `VariantToJson` can only decode unshredded storage, so producing a typed_value child
113+
// here would create an array that fails at decompression time.
114+
vortex_ensure!(
115+
parquet_variant.typed_value_array().is_none(),
116+
"JsonToVariantScheme does not support shredded (typed_value) Parquet Variant storage"
117+
);
128118

129119
let variant_validity = parquet_variant
130120
.validity()?
@@ -133,7 +123,7 @@ impl Scheme for JsonToVariantScheme {
133123
variant_validity,
134124
compressed_metadata,
135125
compressed_value,
136-
typed_value,
126+
None,
137127
)?
138128
.into_array();
139129

0 commit comments

Comments
 (0)