perf: align buffer to Alignment::DEFAULT_ALIGNMENT = = Alignment::new(256)

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-buffer/src/alignment.rs

@@ -19,6 +19,9 @@ impl Alignment {
     /// Default alignment for device-to-host buffer copies.
     pub const HOST_COPY: Self = Alignment::new(256);
 
+    /// Default alignment for all buffers.
+    pub const DEFAULT_ALIGNMENT: Self = Alignment::new(256);
+
     /// Create a new alignment.
     ///
     /// ## Panics

vortex-buffer/src/buffer.rs

@@ -47,7 +47,7 @@ impl<T> Default for Buffer<T> {
         Self {
             bytes: Bytes::from_static(EMPTY_BACKING),
             length: 0,
-            alignment: Alignment::of::<T>(),
+            alignment: Alignment::DEFAULT_ALIGNMENT,
             _marker: PhantomData,
         }
     }
@@ -101,7 +101,7 @@ impl<T> Buffer<T> {
 
     /// Create a new zeroed `Buffer` with the given value.
     pub fn zeroed(len: usize) -> Self {
-        Self::zeroed_aligned(len, Alignment::of::<T>())
+        Self::zeroed_aligned(len, Alignment::MAX)
     }
 
     /// Create a new zeroed `Buffer` with the given value.
@@ -111,7 +111,7 @@ impl<T> Buffer<T> {
 
     /// Create a new empty `ByteBuffer` with the provided alignment.
     pub fn empty() -> Self {
-        Self::empty_aligned(Alignment::of::<T>())
+        Self::empty_aligned(Alignment::DEFAULT_ALIGNMENT)
     }
 
     /// Create a new empty `ByteBuffer` with the provided alignment.
@@ -150,7 +150,7 @@ impl<T> Buffer<T> {
     /// the size of `T`.
     pub fn from_byte_buffer(buffer: ByteBuffer) -> Self {
         // TODO(ngates): should this preserve the current alignment of the buffer?
-        Self::from_byte_buffer_aligned(buffer, Alignment::of::<T>())
+        Self::from_byte_buffer_aligned(buffer, Alignment::DEFAULT_ALIGNMENT)
     }
 
     /// Create a `Buffer<T>` zero-copy from a `ByteBuffer`.

vortex-buffer/src/buffer_mut.rs

@@ -34,7 +34,7 @@ pub struct BufferMut<T> {
 impl<T> BufferMut<T> {
     /// Create a new `BufferMut` with the requested alignment and capacity.
     pub fn with_capacity(capacity: usize) -> Self {
-        Self::with_capacity_aligned(capacity, Alignment::of::<T>())
+        Self::with_capacity_aligned(capacity, Alignment::DEFAULT_ALIGNMENT)
     }
 
     /// Create a new `BufferMut` with the requested alignment and capacity.
@@ -60,7 +60,7 @@ impl<T> BufferMut<T> {
 
     /// Create a new zeroed `BufferMut`.
     pub fn zeroed(len: usize) -> Self {
-        Self::zeroed_aligned(len, Alignment::of::<T>())
+        Self::zeroed_aligned(len, Alignment::DEFAULT_ALIGNMENT)
     }
 
     /// Create a new zeroed `BufferMut`.
@@ -79,7 +79,7 @@ impl<T> BufferMut<T> {
 
     /// Create a new empty `BufferMut` with the provided alignment.
     pub fn empty() -> Self {
-        Self::empty_aligned(Alignment::of::<T>())
+        Self::empty_aligned(Alignment::DEFAULT_ALIGNMENT)
     }
 
     /// Create a new empty `BufferMut` with the provided alignment.
@@ -99,7 +99,7 @@ impl<T> BufferMut<T> {
 
     /// Create a mutable scalar buffer by copying the contents of the slice.
     pub fn copy_from(other: impl AsRef<[T]>) -> Self {
-        Self::copy_from_aligned(other, Alignment::of::<T>())
+        Self::copy_from_aligned(other, Alignment::DEFAULT_ALIGNMENT)
     }
 
     /// Create a mutable scalar buffer with the alignment by copying the contents of the slice.