w

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-array/src/arrays/primitive/array/mod.rs

@@ -596,6 +596,9 @@ impl PrimitiveData {
     }
 
     /// Try to extract a mutable buffer from the PrimitiveData with zero copy.
+    ///
+    /// # Panic
+    /// If the buffer is not of type T this will panic
     pub fn try_into_buffer_mut<T: NativePType>(self) -> Result<BufferMut<T>, Buffer<T>> {
         if T::PTYPE != self.ptype() {
             vortex_panic!(

vortex-array/src/arrays/primitive/compute/cast.rs

@@ -136,11 +136,9 @@ where
 
     // If F and T have the same byte width, try to take unique ownership of the buffer.
     let same_bit_width = F::PTYPE.byte_width() == T::PTYPE.byte_width();
-    let owned: Option<BufferMut<F>> = if same_bit_width {
-        array.into_owned().try_into_buffer_mut::<F>().ok()
-    } else {
-        None
-    };
+    let owned: Option<BufferMut<F>> = same_bit_width
+        .then(|| array.into_owned().try_into_buffer_mut::<F>().ok())
+        .flatten();
     let values: &[F] = array.as_slice::<F>();
 
     if infallible {