Skip to content

superposition still needs fixing! #163

Description

@AndreaVolkamer
          So this PR now contains two unrelated changes: one is fixes to the KLIFS subpackage by Dominique, and the other is updating the Biopython version. For the latter, I had already left a review pointing to some problems, which are not yet resolved. Also, as we discussed in our last meeting, the Biopython problem is only a part of the problem with the `superposition` subpackage.

I think the best approach is to separate these two fixes, and first apply the KLIFS fix, which is already working. Also, depending on your decision on how to proceed with separating the two subpackages, there are other updates that need to be done, but first we need to decide on our strategy.
As I mentioned earlier, the best approach in my opinion is to release a new version of the KLIFS subpackage as a standalone package on PyPI. This way the updated KLIFS part will be immediately available to downstream users. I can do this in a couple of hours if you want.

Originally posted by @AAriam in #157 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions