fix: compare daemon version against app version

Author: vilmire

packages/web-core/src/components/dashboard/DashboardVersionBanner.tsx

@@ -4,21 +4,21 @@ import { getMachineDisplayName } from '../../utils/daemon-utils'
 
 interface DashboardVersionBannerProps {
     daemons: DaemonData[]
+    targetVersion?: string | null
     upgradingDaemons: Record<string, 'upgrading' | 'done' | 'error'>
     onUpgrade: (daemonId: string) => void
     onDismiss: () => void
 }
 
 export default function DashboardVersionBanner({
     daemons,
+    targetVersion,
     upgradingDaemons,
     onUpgrade,
     onDismiss,
 }: DashboardVersionBannerProps) {
     if (daemons.length === 0) return null
 
-    const latest = daemons[0] as any
-
     return (
         <div
             className="flex items-center gap-2.5 px-4 py-2 border-b text-xs text-text-secondary shrink-0 flex-wrap"
@@ -27,11 +27,12 @@ export default function DashboardVersionBanner({
             <span className="text-sm shrink-0 mt-0.5" style={{ color: 'var(--status-warning)' }}><IconRefresh size={14} /></span>
             <span className="flex-1 flex items-center gap-2 flex-wrap min-w-0">
                 <span>
-                    Update available: <strong>v{latest.version}</strong> → <strong>v{latest.serverVersion}</strong>
+                    Update available{targetVersion ? <>: <strong>v{targetVersion}</strong></> : null}
                 </span>
                 {daemons.map((daemon: any) => {
                     const name = getMachineDisplayName(daemon, { fallbackId: daemon.id })
                     const state = upgradingDaemons[daemon.id]
+                    const currentVersion = daemon.version || daemon.daemonVersion || 'unknown'
 
                     return (
                         <span
@@ -40,7 +41,7 @@ export default function DashboardVersionBanner({
                             style={{ background: 'color-mix(in srgb, var(--status-warning) 8%, transparent)', border: '1px solid color-mix(in srgb, var(--status-warning) 15%, transparent)' }}
                         >
                             <span className="font-medium text-text-primary">{name}</span>
-                            <span className="text-[10px] text-text-muted">v{daemon.version}</span>
+                            <span className="text-[10px] text-text-muted">v{currentVersion}</span>
                             {state === 'upgrading' ? (
                                 <span className="text-[10px] animate-pulse" style={{ color: 'var(--status-warning)' }}>upgrading…</span>
                             ) : state === 'done' ? (

packages/web-core/src/hooks/useDashboardVersionBanner.ts

@@ -1,6 +1,8 @@
 import { useCallback, useMemo, useState } from 'react'
 import type { DaemonData } from '../types'
 
+declare const __APP_VERSION__: string
+
 interface UseDashboardVersionBannerOptions {
     ides: DaemonData[]
     sendDaemonCommand: (id: string, type: string, data: Record<string, unknown>) => Promise<any>
@@ -10,9 +12,15 @@ export function useDashboardVersionBanner({
     ides,
     sendDaemonCommand,
 }: UseDashboardVersionBannerOptions) {
+    const appVersion = typeof __APP_VERSION__ !== 'undefined' ? __APP_VERSION__ : null
     const versionMismatchDaemons = useMemo(
-        () => ides.filter((daemon: any) => daemon.type === 'adhdev-daemon' && daemon.versionMismatch),
-        [ides],
+        () => ides.filter((daemon: any) => {
+            if (daemon.type !== 'adhdev-daemon') return false
+            const daemonVersion = daemon.version || daemon.daemonVersion || null
+            if (!daemonVersion || !appVersion) return false
+            return daemonVersion !== appVersion
+        }),
+        [appVersion, ides],
     )
     const [versionBannerDismissed, setVersionBannerDismissed] = useState(false)
     const [upgradingDaemons, setUpgradingDaemons] = useState<Record<string, 'upgrading' | 'done' | 'error'>>({})
@@ -33,6 +41,7 @@ export function useDashboardVersionBanner({
 
     return {
         versionMismatchDaemons,
+        appVersion,
         versionBannerDismissed,
         setVersionBannerDismissed,
         upgradingDaemons,

packages/web-core/src/pages/Dashboard.tsx

@@ -216,6 +216,7 @@ export default function Dashboard() {
 
     const {
         versionMismatchDaemons,
+        appVersion,
         versionBannerDismissed,
         setVersionBannerDismissed,
         upgradingDaemons,
@@ -233,6 +234,7 @@ export default function Dashboard() {
             {!versionBannerDismissed && (
                 <DashboardVersionBanner
                     daemons={versionMismatchDaemons}
+                    targetVersion={appVersion}
                     upgradingDaemons={upgradingDaemons}
                     onUpgrade={handleBannerUpgrade}
                     onDismiss={() => setVersionBannerDismissed(true)}