What
Localization change in multiple xml is needed to conform to vanilla and other RJW hediff text styles. I initially noticed it for the "Blue balls" hediff but now see more hediffs are affected.
Currently, the states are:
- Blue balls (noticable)
- Blue balls (swollen)
- Blue balls (aching)
I suggest changing it to:
- Blue balls (Noticable)
- Blue balls (Swollen)
- Blue balls (Aching)
Why
-
Vanilla body parts are styled like "Prosthetic leg" with a capital letter in first word only.
✅Cumpilation currently complies with this.
-
Labels for health conditions are labeled in parenthesis, example from RJW: "Penis (Small)" with capital letter for the label.
❌I did a quick search for tags and see that pretty much all XML files are not conforming to this standard.
Affected files
A lot. I did a grep command to find files containging followed by a lower case letter. In total there is 68 files affected.
Cmd for finding affected files: grep -rlE '<label>[a-z]+' .
Cmd for counting them: grep -rlE '<label>[a-z]+' . | wc -l
./1.6/Mods/Biotech/Defs/SexFluidDefs/Slug.xml
./1.6/Mods/Biotech/Defs/HediffDefs/SlugStuffed.xml
./1.6/Mods/Biotech/Defs/HediffDefs/TemporarySlugged.xml
./1.6/Mods/Biotech/Defs/HediffDefs/SlugBukkake.xml
./1.6/Mods/Biotech/Defs/RecordDefs/Record_SlugConsumption.xml
./1.6/Mods/Biotech/Defs/ThoughtDefs/Thought_ConsumedSlug.xml
./1.6/Mods/Biotech/Defs/ThoughtDefs/Thought_SlugStuffed.xml
./1.6/Mods/Biotech/Defs/ThingDefs/Drug_ChangeFluid.xml
./1.6/Mods/Ideology/Patches/Patch_Biosculptor_AddNewCycles.xml
./1.6/Mods/Ideology/Defs/Thoughts/Thought_Biosculptor_FluidIncrease.xml
./1.6/Mods/Not-Semen-Processor/Defs/Resource_CumResources.xml
./1.6/Mods/Not-Semen-Processor/Defs/Recipies_CumResources.xml
./1.6/Defs/ThingFilterDefs/Cum_Food_Restrictions.xml
./1.6/Defs/RecipeDefs/Recipes_Surgery_Deflate.xml
./1.6/Defs/TraitDefs/Likes_Cumflation_Trait.xml
./1.6/Defs/HediffDefs/Bukkake.xml
./1.6/Defs/HediffDefs/Leaking.xml
./1.6/Defs/HediffDefs/TemporaryFluidChange.xml
./1.6/Defs/HediffDefs/Oscillation.xml
./1.6/Defs/HediffDefs/Cumflation.xml
./1.6/Defs/HediffDefs/Cumstuffed.xml
./1.6/Defs/HediffDefs/Temporary_FluidBuff.xml
./1.6/Defs/RecordDefs/Records_FluidConsumption.xml
./1.6/Defs/ThoughtDefs/Thoughts_Memory_Stuffing.xml
./1.6/Defs/ThoughtDefs/Thoughts_Leaking.xml
./1.6/Defs/ThoughtDefs/Thoughts_Memory_Cumflation.xml
./1.6/Defs/ThoughtDefs/Thoughts_ConsumedFluid.xml
./1.6/Defs/ThoughtDefs/Thoughts_Social_LikesCumflation.xml
./1.6/Defs/WorkGivers/WorkGiver_CleanSelf.xml
./1.6/Defs/ThingDefs/Buildings_Cum.xml
./1.6/Defs/ThingDefs/Drug_FluidBuff.xml
./1.6/Defs/ThingDefs/Apparel_Plug.xml
./1.6/Defs/ThingDefs/Resource_Cum.xml
./1.6/Defs/ThingDefs/Buildings_Furniture.xml
./1.5/Mods/Biotech/Defs/SexFluidDefs/Slug.xml
./1.5/Mods/Biotech/Defs/HediffDefs/SlugStuffed.xml
./1.5/Mods/Biotech/Defs/HediffDefs/TemporarySlugged.xml
./1.5/Mods/Biotech/Defs/HediffDefs/SlugBukkake.xml
./1.5/Mods/Biotech/Defs/RecordDefs/Record_SlugConsumption.xml
./1.5/Mods/Biotech/Defs/ThoughtDefs/Thought_ConsumedSlug.xml
./1.5/Mods/Biotech/Defs/ThoughtDefs/Thought_SlugStuffed.xml
./1.5/Mods/Biotech/Defs/ThingDefs/Drug_ChangeFluid.xml
./1.5/Mods/Ideology/Patches/Patch_Biosculptor_AddNewCycles.xml
./1.5/Mods/Ideology/Defs/Thoughts/Thought_Biosculptor_FluidIncrease.xml
./1.5/Mods/Not-Semen-Processor/Defs/Resource_CumResources.xml
./1.5/Mods/Not-Semen-Processor/Defs/Recipies_CumResources.xml
./1.5/Defs/ThingFilterDefs/Cum_Food_Restrictions.xml
./1.5/Defs/RecipeDefs/Recipes_Surgery_Deflate.xml
./1.5/Defs/TraitDefs/Likes_Cumflation_Trait.xml
./1.5/Defs/HediffDefs/Bukkake.xml
./1.5/Defs/HediffDefs/Leaking.xml
./1.5/Defs/HediffDefs/TemporaryFluidChange.xml
./1.5/Defs/HediffDefs/Oscillation.xml
./1.5/Defs/HediffDefs/Cumflation.xml
./1.5/Defs/HediffDefs/Cumstuffed.xml
./1.5/Defs/HediffDefs/Temporary_FluidBuff.xml
./1.5/Defs/RecordDefs/Records_FluidConsumption.xml
./1.5/Defs/ThoughtDefs/Thoughts_Memory_Stuffing.xml
./1.5/Defs/ThoughtDefs/Thoughts_Leaking.xml
./1.5/Defs/ThoughtDefs/Thoughts_Memory_Cumflation.xml
./1.5/Defs/ThoughtDefs/Thoughts_ConsumedFluid.xml
./1.5/Defs/ThoughtDefs/Thoughts_Social_LikesCumflation.xml
./1.5/Defs/WorkGivers/WorkGiver_CleanSelf.xml
./1.5/Defs/ThingDefs/Buildings_Cum.xml
./1.5/Defs/ThingDefs/Drug_FluidBuff.xml
./1.5/Defs/ThingDefs/Apparel_Plug.xml
./1.5/Defs/ThingDefs/Resource_Cum.xml
./1.5/Defs/ThingDefs/Buildings_Furniture.xml
Suggested solution
I can make a PR if you agree that this should be implemented! 🤩 Should be quite simple to update, might take a while to go work through every file though.
Note: I usually use Gitgud so might be a bit delayed if any comments are added here! ^-^
What
Localization change in multiple xml is needed to conform to vanilla and other RJW hediff text styles. I initially noticed it for the "Blue balls" hediff but now see more hediffs are affected.
Currently, the states are:
I suggest changing it to:
Why
Vanilla body parts are styled like "Prosthetic leg" with a capital letter in first word only.
✅Cumpilation currently complies with this.
Labels for health conditions are labeled in parenthesis, example from RJW: "Penis (Small)" with capital letter for the label.
❌I did a quick search for tags and see that pretty much all XML files are not conforming to this standard.
Affected files
A lot. I did a grep command to find files containging followed by a lower case letter. In total there is 68 files affected.
Cmd for finding affected files:
grep -rlE '<label>[a-z]+' .Cmd for counting them:
grep -rlE '<label>[a-z]+' . | wc -lSuggested solution
I can make a PR if you agree that this should be implemented! 🤩 Should be quite simple to update, might take a while to go work through every file though.
Note: I usually use Gitgud so might be a bit delayed if any comments are added here! ^-^