Skip to content

fix(client): ConfigSetAsync routes to AllPrimaries instead of AllNodes in cluster mode #492

Description

@currantw

Describe the bug

GlideClusterClient.ConfigSetAsync explicitly routes to AllPrimaries, but glide-core's default routing for CONFIG SET is AllNodes. Configuration changes should propagate to all nodes (including replicas), not just primaries.

This affects both overloads:

  • ConfigSetAsync(IDictionary<ValkeyValue, ValkeyValue>) — the IBaseClient override
  • ConfigSetAsync(ValkeyValue, ValkeyValue) — the cluster-only single key-value convenience method

Expected Behavior

CONFIG SET should be sent to all nodes (AllNodes) so configuration is consistent across the entire cluster.

Current Behavior

Only primary nodes receive the CONFIG SET command, leaving replicas with stale configuration.

Possible Solution

Remove the explicit AllPrimaries route parameter from both ConfigSetAsync overloads so glide-core's correct AllNodes default applies.

Related

Metadata

Metadata

Assignees

Labels

coreCore library (`sources/Valkey.Glide/`)triageNeeds triage — not yet reviewed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions