Skip to content

Add GLIDE interfaces for remaining stream commands #326

Description

@currantw

Summary

Add GLIDE-native interfaces (IBaseClient, IStreamBaseCommands, IBatchStreamCommands) for the remaining stream commands that currently only have SER-compatible implementations on IDatabaseAsync.

Description

PR #324 enabled GLIDE interfaces for core stream commands (XADD, XREAD, XRANGE/XREVRANGE, XREADGROUP, XLEN, XDEL) but temporarily disabled the GLIDE-native methods for the remaining commands. The SER layer (IDatabaseAsync) works for all of them, but the GLIDE layer needs to be re-enabled with proper cleanup.

Commands needing GLIDE interfaces:

  • XGROUP CREATE
  • XGROUP SETID
  • XGROUP DESTROY
  • XGROUP CREATECONSUMER
  • XGROUP DELCONSUMER
  • XCLAIM / XCLAIM JUSTID
  • XAUTOCLAIM / XAUTOCLAIM JUSTID
  • XTRIM
  • XACK
  • XPENDING
  • XINFO STREAM / XINFO STREAM FULL
  • XINFO GROUPS
  • XINFO CONSUMERS

The internal Request layer already supports all of these. The work is to uncomment and clean up the IBaseClient, IStreamBaseCommands, IBatchStreamCommands, and BaseClient methods, ensuring cross-client consistency with Java, Python, Go, and Node GLIDE clients.

Proposed Solution

For each command, uncomment the GLIDE methods on IBaseClient/IStreamBaseCommands/IBatchStreamCommands, verify signatures match other GLIDE clients, and re-enable the corresponding integration tests.

Effort & Severity Estimates

  • Effort: medium
  • Severity: medium

Related

Metadata

Metadata

Assignees

Labels

coreCore library (`sources/Valkey.Glide/`)

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions