The Embedder pins a HuggingFace model revision, but the reranker, SPLADE retriever, and grounding verifier call from_pretrained without a pinned revision=. If HF republishes those weights, benchmark numbers can drift silently.
Scope (good first issue):
- Find the unpinned loads (start at
src/nexusrag/retrieval/reranker.py; also SPLADE + grounding).
- Record each model repo's current commit SHA and add
revision="<sha>" to the call.
- Note the pins in
PROVENANCE.md.
- Re-run
make eval and confirm the committed benchmark numbers still reproduce.
Self-contained; no architecture changes needed.
The Embedder pins a HuggingFace model revision, but the reranker, SPLADE retriever, and grounding verifier call
from_pretrainedwithout a pinnedrevision=. If HF republishes those weights, benchmark numbers can drift silently.Scope (good first issue):
src/nexusrag/retrieval/reranker.py; also SPLADE + grounding).revision="<sha>"to the call.PROVENANCE.md.make evaland confirm the committed benchmark numbers still reproduce.Self-contained; no architecture changes needed.