release: 1.2.1#299
Conversation
The lockfile was inadvertently regenerated with pnpm 9+ in PR #294, producing lockfileVersion 9.0. CI uses pnpm 8.14.0 which cannot honour v9 lockfiles and silently falls back to fresh resolution, causing transitive deps to resolve to incorrect versions and breaking the Docker package build with TS errors in credential-data-integrity. Regenerated with pnpm 8.14.0 (matches Dockerfile/CI), restoring lockfileVersion 6.0.
- Bump version to 1.2.1
Release-As: 1.2.1
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the version to 1.2.1 in package.json, version.json, and CHANGELOG.md. The review feedback identifies that the pnpm-lock.yaml file is missing from the PR, suggests adding the packageManager field to package.json for consistency, and provides a suggestion to fix the comparison link in the changelog.
| { | ||
| "name": "vckit", | ||
| "version": "1.2.0", | ||
| "version": "1.2.1", |
There was a problem hiding this comment.
The pull request description states that the primary fix is the regeneration of pnpm-lock.yaml with pnpm 8.14.0 to restore the Docker build. However, the lockfile is not included in the current changes. Please ensure the updated pnpm-lock.yaml is committed to this PR to resolve the build failure.
| { | ||
| "name": "vckit", | ||
| "version": "1.2.0", | ||
| "version": "1.2.1", |
There was a problem hiding this comment.
To prevent future accidental lockfile regenerations with incompatible pnpm versions (like the one that necessitated this hotfix), consider adding the packageManager field to package.json. This ensures that all contributors and CI environments use the intended pnpm version.
"version": "1.2.1",
"packageManager": "pnpm@8.14.0",| @@ -1,5 +1,18 @@ | |||
| # Change Log | |||
|
|
|||
| ## [1.2.1](https://github.com/uncefact/project-vckit/compare/1.2.0...v1.2.1) (2026-05-01) | |||
There was a problem hiding this comment.
The comparison link for version 1.2.1 uses 1.2.0 as the starting point. For consistency with the tag naming convention used in this repository (which typically uses the v prefix), this should be updated to v1.2.0.
| ## [1.2.1](https://github.com/uncefact/project-vckit/compare/1.2.0...v1.2.1) (2026-05-01) | |
| ## [1.2.1](https://github.com/uncefact/project-vckit/compare/v1.2.0...v1.2.1) (2026-05-01) |
2 participants
This PR ships hotfix 1.2.1, which restores the Docker package build broken in 1.2.0. PR #294 (jsonld upgrade) inadvertently regenerated
pnpm-lock.yamlwith pnpm 9+, producinglockfileVersion: '9.0'. CI uses pnpm 8.14.0 which cannot honour v9 lockfiles, silently fell back to fresh resolution, and resolved transitive deps to versions incompatible with@veramo/credential-ldfrom the gs-gs/veramo workspace. The lockfile has been regenerated with pnpm 8.14.0, restoringlockfileVersion: '6.0'.After merge, the package workflow should successfully build and push the 1.2.1 Docker image to ghcr.io.
Test plan