Skip to content
This repository was archived by the owner on Nov 13, 2021. It is now read-only.
This repository was archived by the owner on Nov 13, 2021. It is now read-only.

Bug in pval computation #24

@zachalexan

Description

@zachalexan

Hello,

I am having difficulty retrieving pvals when method='amoc'.

Looking at this chunk (lines 92-97 in EDM.R):

            over = 1
            for(i in 1:nperm){
                Zcounts = sample(Zcounts)
                stat = Analysis(Zcounts, min.size, alpha)
                if(stat$stat >= retList$stat)
                    over = over + 1

I don't believe retList has been initialized. So stat$stat >= retList$stat is always false. Indeed,
running breakout with nperm=N results in a p-value of 1/(N+1).

Forgive me if I'm pointing out something incorrect or already known. I couldn't find any mention of it here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions