Skip to content

Commit 2a4db16

Browse files
fix(website-new): inherit test target so twenty-shared builds in CI (#20285)
## Summary The new `CI Website` workflow added in #20281 fails on the `test` matrix job because tests cannot resolve `twenty-shared/translations` — a subpath that requires `twenty-shared` to be built first. Root cause: `packages/twenty-website-new/project.json` fully overrides the `test` target, duplicating the executor/options/configurations from `nx.json` `targetDefaults` but **losing `dependsOn: ["^build"]`** (and `inputs` / `cache`). As a result, `nx affected -t test` for `twenty-website-new` does not build `twenty-shared` first. `twenty-front` works because its `project.json` declares `"test": {}` and inherits the full default. This PR does the same for `twenty-website-new`. Verified the diagnosis from the failing run — `front-task (test)` logs show `nx run twenty-shared:build` is invoked transitively, while `website-task (test)` logs do not, leading to the missing-module error.
1 parent d040756 commit 2a4db16

1 file changed

Lines changed: 1 addition & 23 deletions

File tree

packages/twenty-website-new/project.json

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -87,29 +87,7 @@
8787
]
8888
},
8989
"typecheck": {},
90-
"test": {
91-
"executor": "@nx/jest:jest",
92-
"outputs": ["{projectRoot}/coverage"],
93-
"options": {
94-
"jestConfig": "{projectRoot}/jest.config.mjs",
95-
"silent": true,
96-
"coverage": true,
97-
"coverageReporters": ["text-summary"],
98-
"cacheDirectory": "../../.cache/jest/{projectRoot}"
99-
},
100-
"configurations": {
101-
"ci": {
102-
"ci": true,
103-
"maxWorkers": 1
104-
},
105-
"coverage": {
106-
"coverageReporters": ["lcov", "text"]
107-
},
108-
"watch": {
109-
"watch": true
110-
}
111-
}
112-
},
90+
"test": {},
11391
"fmt": {
11492
"options": {
11593
"files": "."

0 commit comments

Comments
 (0)