fix: address review findings (backup, security, recovery docs)#52
Merged
Conversation
Contributor
✅ Validation passedValidation output |
- Longhorn: move backupTarget to defaultBackupStore (v1.11.2 path) - CNPG: add ScheduledBackup for forgejo-db and woodpecker-db - Woodpecker: disable chart-managed agent secret (use SOPS) - Woodpecker: isolate CI jobs in woodpecker-jobs namespace with NetworkPolicy - Add CNPG disaster recovery runbook with PITR instructions - Add GitHub to Forgejo migration guide
turtton
force-pushed
the
fix/review-findings
branch
from
d1839d4 to
675eab1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Oracle reviewで検出された問題への対応:
CRITICAL修正
defaultSettings.backupTarget→defaultBackupStore.backupTargetに修正 (chart v1.11.2の正しいパス)IMPORTANT修正
createAgentSecret: false/mapAgentSecret: falseを追加し、SOPS管理に統一woodpecker-jobsnamespace を新設、RBAC + NetworkPolicy でクラスタ内アクセスを制限ドキュメント追加
docs/cnpg-recovery-runbook.yaml: CNPG災害復旧マニフェスト + PITR手順docs/github-to-forgejo-migration.md: GitHubリポジトリのForgejo移行ガイド