feat: シフト右クリックによるタンク分離設置機能#48
Merged
Merged
Conversation
When placing a tank by shift+right-clicking on a non-tank block, the new tank is placed as an isolated group instead of connecting to adjacent tanks. Clicking directly on a tank while sneaking still connects to that tank's group via interactedAt. Closes #47
- consumeSneaking() now calls remove() to prevent stale state leak - Add block state CONNECTED_* assertions to sneaking isolation test - Add regression test: sneaking does not leak to next normal placement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
シフト右クリックで非タンクブロックに設置した場合、隣接する既存タンクグループに接続されず、独立したグループとして配置される機能を追加。
変更内容
ConnectedTankPlacementContext:sneakingThreadLocal 追加BlockItemPlaceMixin: プレイヤーのisSecondaryUseActive()を記録ConnectedTankBlock.setPlacedBy():sneaking && interactedAt == nullの場合にaddIsolatedStorage()を使用テスト結果
Closes #47