Add support for CTAP 2.3 and release v0.6.0-rc.1#77
Merged
Conversation
0x0ece
approved these changes
May 22, 2026
Contributor
0x0ece
left a comment
There was a problem hiding this comment.
LGTM.
One minor note, since we're bumping the version to 0.6, I might consider including also the "test-client" feature. That allows to serde in both directions, useful for tests. But no strong feeling if you prefer not to.
f6db2f7
(and then we can leave the stack refactor + ml-dsa for a future version).
Member
Author
|
Thanks for the review! I don’t plan to release v0.6.0 directly. Tagging a release candidate just makes incremental updates easier. So I would definitely pull in the other changes (and maybe some more) before doing the actual release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains rebased, cherry-picked and modified commits from #75 to reduce the scope of the changes.
My changes are in the fixup commits except for the ctap2.3 commit where I’ve removed ML-DSA support from the commit itself as it is not directly related to CTAP 2.3. My changes mainly are:
Version::Fido2_2variant: CTAP 2.2 somestimes mentions theFIDO_2_2version but does not define it for theversionsfield ingetInfo. CTAP 2.3 explicitly states: “The string "FIDO_2_2" was not defined for CTAP2.2 and MUST not be present in versions member.”make_credential::ExtensionstoExtensionsInputfor consistency withget_assertion.@0x0ece Please have a look at my changes, especially regarding the
FIDO_2_2version.