Log non-critical chunk errors at V(2).Info instead of Error (#4928)

johnelliott · web-flow · commit cf31c26af313 · 2026-04-29T13:03:00.000-04:00
Non-fatal scanning errors aren't really "errors" - they're consequences of the vicissitudes of scanning a ton of data. They're actionable if you're looking for them but if you're not they're extremely noisy. This commit downgrades them to only show up when you look for them.
diff --git a/pkg/handlers/handlers.go b/pkg/handlers/handlers.go
@@ -425,7 +425,7 @@ func handleChunksWithError(
 				if isFatal(dataOrErr.Err) {
 					return dataOrErr.Err
 				}
-				ctx.Logger().Error(dataOrErr.Err, "non-critical error processing chunk")
+				ctx.Logger().V(2).Info("non-critical error processing chunk", "error", dataOrErr.Err)
 				continue
 			}
 			if len(dataOrErr.Data) > 0 {

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,7 @@ func handleChunksWithError(`
`425`	`425`	`if isFatal(dataOrErr.Err) {`
`426`	`426`	`return dataOrErr.Err`
`427`	`427`	`}`
`428`		`- ctx.Logger().Error(dataOrErr.Err, "non-critical error processing chunk")`
	`428`	`+ ctx.Logger().V(2).Info("non-critical error processing chunk", "error", dataOrErr.Err)`
`429`	`429`	`continue`
`430`	`430`	`}`
`431`	`431`	`if len(dataOrErr.Data) > 0 {`