issue with displaying validation errors when there are multiple forms on the same page

[jchouix]

Hey,
I'm having trouble displaying validation errors after a form submission when there are multiple forms on the same page. The validation errors are no longer displayed because the variable $_SESSION['form_submission_errors'] is cleared before it can be used for displaying validation errors..
The problem comes from line 293 of the form_close() function in the form.php file located in the modules/form/ directory.

// unset($_SESSION['form_submission_errors']);
This code on line 293 clears this variable $_SESSION['form_submission_errors'].

I don't think this line of code is necessary (but I could be wrong) because the validation_errors() function clears this variable $_SESSION['form_submission_errors'] after the errors are displayed.

Regards.

[trongate]

I can't fix it. It's such a bizarre edge case that it's just not worth the time. Forgive me, but I have to wave the white flag with that one.

If you can fix it you'll be a hero. I can't.

DC

[jchouix]

Hi DC,
since I like simple solutions, I suggest simply removing this line of code
unset($_SESSION['form_submission_errors']); ,which isn't essential in the form_close() function because it's already handled in the validation_errors() function.
Regards.

[trongate]

Thanks for the speedy response. What you've said is probably cool but you're proposing messing with what is arguably the most complicated part of the entire framework. Getting that right was horrendously difficult. Let me be honest with you. I'm scared. I'm scared of breaking something.

If you want to do a pull request then I'll have some very powerful AI look into it and I'm sure that Dafa and some of the others will have a look too. I just can't do it. I don't have the confidence.

Peace and love!

DC