Skip to content

delta proxy returns HTTP 200 on a proxy-error, should be 5xx #1018

@crandles

Description

@crandles

Reported via #1016. When DPC collapses an upstream or internal failure into LookupStatusProxyError, the client gets HTTP 200 with an empty body instead of a 5xx.

The error result is built in buildErrorResult (deltaproxycache.go:287-294) and written at deltaproxycache.go:511-517 via Respond(w, result.statusCode, ...), so it emits whatever doc.StatusCode happened to be. Worth confirming where the 200 comes from (the recovered Splice panic vs. an empty/zero-status doc) and making proxy errors surface as 5xx.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdelta-proxyaffects the delta proxy+cacheneeds investigationthis issue requires investigation and does not have a root cause or proposed solution

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions