Skip to content

tsm imports rr directly for its non-merge fallback -- investigate #1009

@crandles

Description

@crandles

tsm is the only ALB mechanism that imports another mechanism. In pkg/backends/alb/mech/tsm/time_series_merge.go:

nmh, _ := rr.New(nil, nil)
nmpm, _ := nmh.(types.PoolMechanism)

no other mechanism is imported by another mechanism. this isn't inherently wrong, but is somewhat unexpected from the package layout.

Worth understanding before changing:

  • is round-robin specifically the right default for the non-merge path, or just the simplest dispatcher on hand?
  • are there cases where the non-merge path should match the operator's chosen primary mechanism rather than always being rr?

To Do:

  • research alternatives

Metadata

Metadata

Assignees

No one assigned

    Labels

    albaffects the application load balancerneeds investigationthis issue requires investigation and does not have a root cause or proposed solutionrefactorOptimize or modernize existing codetsmergeissue affects Time Series Merge

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions